-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
colors are off, for typescript #312
Comments
This is true. I remember this difference when revamping the highlights, and this outcome was intentional. This is essentially how JavaScript is highlighted on github.com (i.e. with class names and the TLDR: alot of langs needed to be revamped at once and it was simply less work to borrow/resuse this from the JavaScript highlighting, plus I thought it was better having these highlights included for TypeScript Feel free to share your own thoughts on this decision if you disagree. |
Maybe Tsconst t = this.method(); Jsconst t = this.method(); Also, the default ;; extends
["const"] @keyword.modifier ...and put that in a file at require('github-theme').setup({ groups = { all = { ['@keyword.modifier'] = { ... } } } }) Note Replace To clear or set the hl for ['@variable.builtin.typescript'] = {}, -- empty table (clears hl), or
['@variable.builtin.typescript'] = { fg = 'fg' }, -- for when an empty tbl doesn't work (actually sets fg to global fg) and add that to Or, you can override builtin variables at a higher level: require('github-theme').setup {
spec = { all = { syntax = { builtin0 = { ... } } } } }
} |
Hi, I started using your plugin very recently. I am in love with it and really appreciate all the efforts. I wanted to submit the following issue:
The colors are off, for typescript.
Attaching screenshots:
As you can see, the colors for class name and types of class properties are different from github.com.
The text was updated successfully, but these errors were encountered: