[prometheus-postgres-exporter] Implement multiple target with /probe … #5012
+64
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endpoint Signed-off-by: festeveira <f.esteveira@hotmail.com>
festeveira
requested review from
gianrubio,
zanhsieh and
zeritti
as code owners
Signed-off-by: Francisco Esteveira <56481538+festeveira@users.noreply.github.com>
zanhsieh
approved these changes
Nov 29, 2024
zeritti
requested changes
Nov 29, 2024
There was a problem hiding this comment.
Thank you, @festeveira, for your PR. Please, see my comments below.
Comment on lines
+64
to
+67
| targets: [] | ||
| # - endpoint: | ||
| # name: | ||
| # port: default 5432 |
There was a problem hiding this comment.
Please, add sample values in the comments, e.g.
Suggested change
| targets: [] | |
| # - endpoint: | |
| # name: | |
| # port: default 5432 | |
| targets: [] | |
| # - endpoint: pg01.local | |
| # name: pg01 | |
| # port: 5432 |
| @@ -50,6 +50,22 @@ serviceMonitor: | |||
| # TLS configuration to use when scraping the metric endpoint by Prometheus. | |||
| # tlsConfig: {} | |||
|
|
|||
| # Use multipleTarget mode | |||
| multipleTargets: | |||
There was a problem hiding this comment.
I'd suggest to rename multipleTargets to multipleTarget as the latter is already used in a few charts in the repository.
Suggested change
| multipleTargets: | |
| multipleTarget: |
| {{- end }} | ||
| params: | ||
| target: | ||
| - {{ .endpoint }}:{{ .port | default 5432 }}/postgres |
There was a problem hiding this comment.
Are you sure about the path /postgres?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…endpoint
What this PR does / why we need it
This PR allows the user to use the multiple target support implemented by the exporter. It allows defining several postgres database targets, using the same or different auth modules.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])