[alertmanager] fix: Add apiVersion and kind to STS persistent volume claim #5024
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 27, 2024 12:17
…r charts API version and kind is added by API server which causes a drift in argo cd state Signed-off-by: Nguyễn Đức Huy <duchuyvp123@gmail.com>
Signed-off-by: Nguyễn Đức Huy <duchuyvp123@gmail.com>
|
This is what I see in argocd, adding the missing field would resolve this and it is not doing any charm
|
|
@naseemkullah can you take a look? |
|
This pull request is similar to #4610 so it would be great if this could be merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Add explicitly
persistentVolumeClaimAPI version and kind - they are added by API server which causes a drift in argocd state - and having them do not make any charm.Which issue this PR fixes
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])