From 1e3b177e34da2bf5bdae7a8003807fc18132e172 Mon Sep 17 00:00:00 2001 From: Joe Adams Date: Wed, 22 Mar 2023 20:54:00 -0400 Subject: [PATCH] Fix column type for pg_replication_slots Change the data type of `active` from int64 to bool. The documentation confirms that this is a boolean field. https://www.postgresql.org/docs/current/view-pg-replication-slots.html fixes #769 Signed-off-by: Joe Adams --- collector/replication_slots.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/collector/replication_slots.go b/collector/replication_slots.go index ed37441cc..a9cad77df 100644 --- a/collector/replication_slots.go +++ b/collector/replication_slots.go @@ -69,7 +69,7 @@ func (PGReplicationSlotCollector) Update(ctx context.Context, db *sql.DB, ch cha var slot_name string var wal_lsn int64 var flush_lsn int64 - var is_active int64 + var is_active bool if err := rows.Scan(&slot_name, &wal_lsn, &flush_lsn, &is_active); err != nil { return err } @@ -78,7 +78,7 @@ func (PGReplicationSlotCollector) Update(ctx context.Context, db *sql.DB, ch cha pgReplicationSlot["current_wal_lsn"], prometheus.GaugeValue, float64(wal_lsn), slot_name, ) - if is_active == 1 { + if is_active { ch <- prometheus.MustNewConstMetric( pgReplicationSlot["confirmed_flush_lsn"], prometheus.GaugeValue, float64(flush_lsn), slot_name,