Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new metadata endpoint to retrieve data for hover and completion #76

Closed
slrtbtfs opened this issue Dec 12, 2019 · 7 comments · Fixed by #125
Closed

Use new metadata endpoint to retrieve data for hover and completion #76

slrtbtfs opened this issue Dec 12, 2019 · 7 comments · Fixed by #125
Labels
enhancement New feature or request

Comments

@slrtbtfs
Copy link
Member

See prometheus/prometheus#6395 .
@slrtbtfs slrtbtfs added the enhancement New feature or request label Dec 12, 2019
@slrtbtfs
Copy link
Member Author

This allows for more correct metadata on hover and more better metadata on completion.

@slrtbtfs
Copy link
Member Author

It should be considered to add some compatibility check to avoid breakage with Prometheus Versions that do not support the new API.

1 similar comment
@slrtbtfs
Copy link
Member Author

It should be considered to add some compatibility check to avoid breakage with Prometheus Versions that do not support the new API.

@slrtbtfs
Copy link
Member Author

Depends on prometheus/client_golang#705 .

@slrtbtfs slrtbtfs added the upstream Bugs that have to be fixed in a dependency label Jan 20, 2020
@slrtbtfs slrtbtfs removed the upstream Bugs that have to be fixed in a dependency label Feb 28, 2020
@weastel
Copy link
Contributor

weastel commented Mar 11, 2020

@slrtbtfs Any plans. I would like to work on this as

Depends on prometheus/client_golang#705 .

is closed.

@slrtbtfs
Copy link
Member Author

@drumilpatel2000 Currently no one is working on this, so a PR would be appreciated.

It might make sense to first do a PR where the response here is used to check the version of the connected Prometheus instance, since the new metadata endpoint is only supported since Prometheus version 2.15 .

@weastel weastel mentioned this issue Mar 12, 2020
Merged
@slrtbtfs
Copy link
Member Author

slrtbtfs commented Mar 14, 2020 •
edited
Loading

The metadata API can be used here as well, so this issue is not yet closed.

@weastel weastel mentioned this issue Mar 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use metadata apis for completion weastel/promql-langserver
2 participants
@slrtbtfs @weastel