Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi cluster alert rule queries #2056

Closed
jaygridley opened this issue Mar 27, 2023 · 2 comments · Fixed by #2099
Closed

Add support for multi cluster alert rule queries #2056

jaygridley opened this issue Mar 27, 2023 · 2 comments · Fixed by #2099

Comments

@jaygridley
Copy link

What is missing?

A Bunch of Prometheus alert rules do not support multi-cluster setup. For example KubeAPITerminatedRequests should group metric by cluster, ie. sum by (cluster) (rate(apiserver_request_terminations_total{job="apiserver"}[10m])) / ( sum by (cluster) (rate(apiserver_request_total{job="apiserver"}[10m])) + sum by (cluster) (rate(apiserver_request_terminations_total{job="apiserver"}[10m])) ) > 0.20.

List of alerts lacking multi-cluster support:

  • KubeCPUQuotaOvercommit
  • KubeMemoryQuotaOvercommit
  • KubeStateMetricsListErrors
  • KubeStateMetricsShardingMismatch
  • KubeStateMetricsShardsMissing
  • KubeStateMetricsWatchErrors
  • PrometheusOperatorListErrors
  • PrometheusOperatorNotReady
  • PrometheusOperatorReconcileErrors
  • PrometheusOperatorWatchErrors
  • TargetDown

Why do we need it?

Environment

  • kube-prometheus version:

    8.4.1

Anything else we need to know?:

Other alerts already do support this, ie. https://github.com/prometheus-operator/kube-prometheus/blob/main/manifests/kubernetesControlPlane-prometheusRule.yaml#L551

@jkroepke
Copy link
Contributor

jkroepke commented May 3, 2023

Having the same issue. I guess we have to contribute by own?

@jkroepke
Copy link
Contributor

jkroepke commented May 5, 2023

For

KubeStateMetricsListErrors
KubeStateMetricsShardingMismatch
KubeStateMetricsShardsMissing
KubeStateMetricsWatchErrors

See: kubernetes/kube-state-metrics#2058 then it can be implemented as well here. too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants