Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add support for WebSocket #1081

Open
thevops opened this issue Jun 23, 2023 · 4 comments
Open

Request to add support for WebSocket #1081

thevops opened this issue Jun 23, 2023 · 4 comments

Comments

@thevops
Copy link

thevops commented Jun 23, 2023

There is an old issue about WebSocket probe: #536

It'd be nice to reconsider adding WebSocket support to Blackbox. The popularity of this protocol is growing.
What do you think?

@SuperQ
Copy link
Member

SuperQ commented Jun 23, 2023

Seems like a good idea. Can you write out a proposal for what this would look like? What additional parameters / features would be needed.

@thevops
Copy link
Author

thevops commented Jun 26, 2023

Proposal

The popularity of the WebSocket protocol is growing. Having support for this protocol would be very useful.

Features

The WebSocket probe could have the same attributes as the HTTP probe, like support for Basic Auth or TLS checking. Although a Minimum Viable Product can support only essential functions: sending requests with query data, receiving answers, and comparing received data to expected data.

Feedback

I’m ready to test the WebSocket probe implementation, provide feedback and contribute as much as I can.

@muety
Copy link

muety commented Oct 1, 2024

Any changes to have blackbox exporter support websocket any time soon?

@adnull
Copy link

adnull commented Oct 1, 2024

@muety as the PR is still not accepted you can try using websocket support version directly from my repo.
https://github.com/adnull/blackbox_exporter/tree/websocket-support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants