Replies: 1 comment 1 reply
-
Hmm, the method name has also diverged from the name in the doc comment ( |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
https://github.com/prometheus/client_golang/blame/main/prometheus/summary.go#L355, this comment says this method requires both
mtx AND bufMtx locked
, but from what I understood, the call site doesn't lockbufMtx
, for example https://github.com/prometheus/client_golang/blame/main/prometheus/summary.go#L306. Also the comment offlushColdBuf
doesn't mention it.Beta Was this translation helpful? Give feedback.
All reactions