-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestGoCollectorAllowList tests fail in v1.13.0 with Go 1.19 #1135
Comments
I presume that this test will need special handling for Go 1.17 / 1.18, and 1.19, as per the prometheus/go_collector_metrics_go1{17,18,19}_test.go files. Specifically, Go 1.19 seems to expose four additional metrics:
|
work fine with me on go1.18.6. some fail on 1.19. |
See my second comment. Updated title to avoid confusion. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following tests fail in v1.13.0 and main branch (as of writing).
Tested with Go 1.19.1 on linux/amd64, running kernel 5.19.
I'm not sure how this got past Circle CI, assuming that it runs tests. The release notes state "we also test client_golang against the new 1.19 version", but this doesn't appear to be true:
The text was updated successfully, but these errors were encountered: