-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exemplar for +Inf
bucket adds bucket with wrong value
#1147
Comments
I'll open a PR shortly |
Thanks! Approved fix with some small nit. |
Thanks for merging it, @bwplotka. When can we expect it to get released? |
Can you just use commit sha for now? We will release soon, but don't know when (KubeCom + PromCon is coming) |
Note your link to the problem now shows the fixed code, because it references client_golang/prometheus/metric.go Lines 188 to 190 in 3faf3ba
|
When writing histogram metrics, and there is an exemplar for the
+Inf
bucket, then the+Inf
bucket is added with the value of the previous bucket:https://github.com/prometheus/client_golang/blob/main/prometheus/metric.go#L188
This is incorrect, as the cumulative count of the
+Inf
bucket should instead be added with the total count of the histogram datapoint.The above behaviour results in invalid values being reported for the
+Inf
bucket.The text was updated successfully, but these errors were encountered: