Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: Execution order on multiple return variables with multiple vars is unspecified (and does not work with gogc) #1259

Closed
zigo101 opened this issue Apr 26, 2023 · 1 comment · Fixed by #1260
Closed

api: Execution order on multiple return variables with multiple vars is unspecified (and does not work with gogc) #1259

zigo101 opened this issue Apr 26, 2023 · 1 comment · Fixed by #1260
Labels
bug good first issue help wanted

Comments

@zigo101
Copy link

zigo101 commented Apr 26, 2023

https://github.com/prometheus/client_golang/blob/main/api/prometheus/v1/api.go#L894-L895

More details: golang/go#58233 (comment)
@bwplotka bwplotka changed the title Unprofessional code depending on unspecified behavior api: Execution order on multiple return variables with multiple vars is unspecified (and does not work with gogc) Apr 26, 2023
@bwplotka
Copy link
Member

Wow, first time I saw this being an issue, thanks for reporting. Help wanted to fix it.

@PiotrLewandowski323 PiotrLewandowski323 mentioned this issue Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix undefined execution order in return statements
2 participants
@bwplotka @zigo101