-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locally reproducible CI/CD #1436
Comments
Hi @kakkoyun, navigated here form the LFX portal. Since this is particularly about unit testing in specific environments, We can allow contributors to specify the Go version they want to use through environment variables and modify the CI/CD scripts to interpret these variables and set up the corresponding Go version for testing. We certainly will have to find a way to manage dependencies. Or how about using 3 different docker images for 3 test environments? What are your thoughts? |
hey there! I'm coming from this X thread: https://twitter.com/ArthurSilvaSens/status/1791069622508179854. Seems like https://dagger.io could help here. @juliusv mentioned that the prom team tried to use Dagger in the past without success but a lot have changed since then and this particular problematic is exactly the problem Dagger tries to solve. Happy to take a look and collaborate on a PoC if you're interested 👐 |
What exactly is not reproducible at the moment? Let's talk about specifics. I heard testing for certain Go version as a one thing. |
I never claimed it's not reproducible. The idea is to be able to run anything we use in the CI locally https://github.com/prometheus/client_golang/tree/main/.github/workflows with the least amount of effort. Technically, we can have make actions for everything and it could be the single source of truth or we can go with something fancy like https://dagger.io |
@bwplotka @kakkoyun happy to help putting together a PoC with Dagger so you can decide if it's worth or not. LMK if there's interest and I can kick off a draft PR and we can discuss there maybe with more tangible examples on how this could work. |
@marcosnils Thanks 🤩 Why not? I would be happy to review. |
@kakkoyun funny thing is that first thimg I did after cloning the repo is calling
couldn't find an easy way to unblock myself. Any ideas where I should be getting that .promu.yml file from? |
We want vendor-independent and locally reproducible CI/CD pipelines so that our contributors can ensure quality before opening the pull requests.
The text was updated successfully, but these errors were encountered: