Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip label removal/readd if PR description changed by type didn't #1548

Closed
Tracked by #1546
ArthurSens opened this issue Jun 28, 2024 · 0 comments
Closed
Tracked by #1546

Skip label removal/readd if PR description changed by type didn't #1548

ArthurSens opened this issue Jun 28, 2024 · 0 comments

Comments

@ArthurSens
Copy link
Member

ArthurSens commented Jun 28, 2024

In our current auto-label workflow, when a PR is edited, we first remove the changelog-related label and after that we re-add them.

We see two problems with this:

  • If a PR description changes but /kind doesn't, we're doing unnecessary work when we remove and re-add the same thing.
  • We've been noticing some race conditions (not sure where exactly). Sometimes the label is removed but is not re-added again, causing the workflow to fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant