We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This simple test case showcases the problem:
func TestRegisterUnregisterCollector(t *testing.T) { col := prometheus.NewGoCollector() reg := prometheus.NewRegistry() reg.MustRegister(col) reg.Unregister(col) if metrics, err := reg.Gather(); err != nil { t.Error("error gathering sample metric") } else if len(metrics) != 0 { t.Error("should have unregistered metric") } }
This passed up to v1.1.0, but fails on v1.2.0 (and master).
The calculation of collectorID got changed in 1.2.0 and the same change was not applied to unregistering. PR follows shortly.
The text was updated successfully, but these errors were encountered:
Ouch. Thanks for spotting.
Perils of code duplication. But with #663, there will be a test.
Sorry, something went wrong.
Happy to help! :)
v1.2.1 coming.
Successfully merging a pull request may close this issue.
This simple test case showcases the problem:
This passed up to v1.1.0, but fails on v1.2.0 (and master).
The calculation of collectorID got changed in 1.2.0 and the same change was not applied to unregistering. PR follows shortly.
The text was updated successfully, but these errors were encountered: