Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histograms: Port the protobuf changes to the OpenMetrics protobuf spec #60

Closed
beorn7 opened this issue Sep 6, 2022 · 3 comments
Closed
Assignees

Comments

@beorn7
Copy link
Member

beorn7 commented Sep 6, 2022

The changes made here to the protobuf spec to accommodate Native Histograms (AKA Sparse Histograms) only affect the old Prometheus protobuf format, which is hardly used (and had to be brought back in prometheus/prometheus just for the histogram experiment).

However, it is likely that the changes will easily translate to the OpenMetrics protobuf spec, see https://github.com/OpenObservability/OpenMetrics/blob/main/proto/openmetrics_data_model.proto .

This issue is about exploring that possibility. If it looks feasible, open a PR against https://github.com/OpenObservability/OpenMetrics , which would be an easy way to bring Native Histograms to OpenMetrics without first solving the problems around representing Native Histograms in the OM text format (cf. OpenObservability/OpenMetrics#237 ).

Corollary: prometheus/prometheus should then also support the OpenMetrics protobuf format. With a bit of luck, this will be easy to implement based on the protobuf parsing code created for the histogram experiment, see first paragraph above).

@beorn7
Copy link
Member Author

beorn7 commented Sep 6, 2022

Note that this issue doesn't block merging the sparsehistogram branch of this repo into the master branch.

@beorn7
Copy link
Member Author

beorn7 commented Oct 5, 2022

OpenObservability/OpenMetrics#256 is a draft for how the OpenMetrics protobuf could look like.

@beorn7
Copy link
Member Author

beorn7 commented Jan 25, 2024

OpenObservability/OpenMetrics#256 is not a draft anymore, and it seems to be correct as far as I can know. The reason it isn't merged is that OpenMetrics has to come to terms how to manage this change WRT version numbers etc.

Therefore, I'm closing this issue, as the work is done from prometheus/client_model's POV.

@beorn7 beorn7 closed this as completed Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant