Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add exemplars to pure Native Histograms #61

Closed
beorn7 opened this issue Sep 6, 2022 · 5 comments · Fixed by #80
Closed

How to add exemplars to pure Native Histograms #61

beorn7 opened this issue Sep 6, 2022 · 5 comments · Fixed by #80
Assignees

Comments

@beorn7
Copy link
Member

beorn7 commented Sep 6, 2022

How to deal with exemplars if there are only sparse buckets but no conventional buckets?

We probably need a separate section in the protobuf spec. (There will also be the interesting question how to pick exemplars, but that's not the concern of the exposition format.)

@beorn7 beorn7 added this to the Native Histograms milestone Sep 6, 2022
@beorn7
Copy link
Member Author

beorn7 commented Sep 6, 2022

Note that this issue doesn't block merging the sparsehistogram branch of this repo into the master branch. This feature can be added later without a breaking change.

@fstab
Copy link
Member

fstab commented Nov 17, 2022

OpenTelemetry solved this by just adding a list of Exemplars. Sounds like this would work for Prometheus as well? https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/metrics/v1/metrics.proto#L557

@beorn7
Copy link
Member Author

beorn7 commented Nov 9, 2023

Yes, so we will simply have a repeated exemplar message as an additional field in native histograms. Note, though, that we have to require timestamps for those exemplars (which also happens to be in line with OTel). See prometheus/prometheus#13021 for context.

@fatsheep9146
Copy link
Contributor

@beorn7 can I pick up this issue?

@beorn7
Copy link
Member Author

beorn7 commented Jan 15, 2024

Yes, sure. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants