-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to add exemplars to pure Native Histograms #61
Comments
Note that this issue doesn't block merging the sparsehistogram branch of this repo into the master branch. This feature can be added later without a breaking change. |
OpenTelemetry solved this by just adding a list of Exemplars. Sounds like this would work for Prometheus as well? https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/metrics/v1/metrics.proto#L557 |
Yes, so we will simply have a repeated exemplar message as an additional field in native histograms. Note, though, that we have to require timestamps for those exemplars (which also happens to be in line with OTel). See prometheus/prometheus#13021 for context. |
@beorn7 can I pick up this issue? |
Yes, sure. Thank you. |
How to deal with exemplars if there are only sparse buckets but no conventional buckets?
We probably need a separate section in the protobuf spec. (There will also be the interesting question how to pick exemplars, but that's not the concern of the exposition format.)
The text was updated successfully, but these errors were encountered: