Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump in prometheus/common breaks client_golang build #578

Closed
shane-ns1 opened this issue Feb 26, 2024 · 3 comments
Closed

Version bump in prometheus/common breaks client_golang build #578

shane-ns1 opened this issue Feb 26, 2024 · 3 comments

Comments

@shane-ns1
Copy link

It looks like the recent version bump of prometheus/common breaks the prometheus/client_golang build. I'm not sure whether this should be fixed in the prometheus/common or the prometheus/client_golang build (I guess probably in the prometheus/client_golang, but it was the prometheus/common version bump which broke things, so I'm filing the issue here):

/go/pkg/mod/github.com/prometheus/client_golang@v1.18.0/prometheus/testutil/promlint/promlint.go:71:38: undefined: expfmt.FmtText

Also, maybe the CI should be changed to spot these issues, since both repositories fall under the same organization in GitHub?

@nicolaasuni-vonage
Copy link

It looks like this is a duplicate of:
#577
that has been prematurely closed?

@shane-ns1
Copy link
Author

Possibly the golang_client code has been fixed, but there is no new release of the code so anyone installing the latest release of both libraries will have this problem.

@SuperQ
Copy link
Member

SuperQ commented Feb 26, 2024

Yes, we close issues once the code has been merged. We will need a new upstream release and bump of Go modules. But the issue can be closed to mark the fix as completed.

Duplicate of #557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants