Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FmtText was removed between v0.42.0 and v0.53.0 #635

Closed
rootulp opened this issue May 27, 2024 · 1 comment
Closed

FmtText was removed between v0.42.0 and v0.53.0 #635

rootulp opened this issue May 27, 2024 · 1 comment

Comments

@rootulp
Copy link

rootulp commented May 27, 2024

I'm upgrading a codebase from

-github.com/prometheus/common v0.42.0
+github.com/prometheus/common v0.53.0

and encountered these errors

telemetry/metrics.go:151:37: undefined: expfmt.FmtText
telemetry/metrics.go:158:51: undefined: expfmt.FmtText

However there was no mention of a deprecation of FmtText in the release notes between v0.42.0 and v0.53.0. When was it removed and what should consumers do instead of calling FmtText?

@rootulp
Copy link
Author

rootulp commented May 27, 2024

It was dropped in this commit which was first included in v0.48.0. v0.48.0 release notes do mention something so I'll look at #576 to try and resolve my issue.

@rootulp rootulp closed this as not planned Won't fix, can't repro, duplicate, stale May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant