Unable to build against the latest version of github.com/prometheus/procfs

[shaardie]

Host operating system: output of uname -a

Linux marciano 5.0.5-arch1-1-ARCH #1 SMP PREEMPT Wed Mar 27 17:53:10 UTC 2019 x86_64 GNU/Linux

node_exporter version: output of node_exporter --version

Not compiling...but source code commit is 4d88761.

node_exporter command line flags

Are you running node_exporter in Docker?

What did you do that produced an error?

$ go get -u github.com/prometheus/procfs
$ make
>> checking code style
>> checking license header
>> running staticcheck
chmod +x /home/sven/devel/go/bin/staticcheck
GO111MODULE=on go list -e -compiled -test=true -export=false -deps=true -find=false -tags= -- ./... > /dev/null
GO111MODULE=on /home/sven/devel/go/bin/staticcheck -ignore "" ./...
collector/xfs_linux.go:47:21: c.fs.XFSStats undefined (type sysfs.FS has no field or method XFSStats) (compile)
collector/nfsd_linux.go:60:21: c.fs.NFSdServerRPCStats undefined (type procfs.FS has no field or method NFSdServerRPCStats) (compile)
collector/nfs_linux.go:94:21: c.fs.NFSClientRPCStats undefined (type procfs.FS has no field or method NFSClientRPCStats) (compile)
collector/bcache_linux.go:52:21: c.fs.BcacheStats undefined (type sysfs.FS has no field or method BcacheStats) (compile)
collector/xfs_linux.go:47:21: c.fs.XFSStats undefined (type sysfs.FS has no field or method XFSStats) (compile)
collector/nfsd_linux.go:60:21: c.fs.NFSdServerRPCStats undefined (type procfs.FS has no field or method NFSdServerRPCStats) (compile)
collector/nfs_linux.go:94:21: c.fs.NFSClientRPCStats undefined (type procfs.FS has no field or method NFSClientRPCStats) (compile)
collector/bcache_linux.go:52:21: c.fs.BcacheStats undefined (type sysfs.FS has no field or method BcacheStats) (compile)
collector/xfs_linux.go:47:21: c.fs.XFSStats undefined (type sysfs.FS has no field or method XFSStats) (compile)
collector/nfsd_linux.go:60:21: c.fs.NFSdServerRPCStats undefined (type procfs.FS has no field or method NFSdServerRPCStats) (compile)
collector/nfs_linux.go:94:21: c.fs.NFSClientRPCStats undefined (type procfs.FS has no field or method NFSClientRPCStats) (compile)
collector/bcache_linux.go:52:21: c.fs.BcacheStats undefined (type sysfs.FS has no field or method BcacheStats) (compile)
collector/xfs_linux.go:47:21: c.fs.XFSStats undefined (type sysfs.FS has no field or method XFSStats) (compile)
collector/nfsd_linux.go:60:21: c.fs.NFSdServerRPCStats undefined (type procfs.FS has no field or method NFSdServerRPCStats) (compile)
collector/nfs_linux.go:94:21: c.fs.NFSClientRPCStats undefined (type procfs.FS has no field or method NFSClientRPCStats) (compile)
collector/bcache_linux.go:52:21: c.fs.BcacheStats undefined (type sysfs.FS has no field or method BcacheStats) (compile)
collector/xfs_linux.go:47:21: c.fs.XFSStats undefined (type sysfs.FS has no field or method XFSStats) (compile)
collector/nfsd_linux.go:60:21: c.fs.NFSdServerRPCStats undefined (type procfs.FS has no field or method NFSdServerRPCStats) (compile)
collector/nfs_linux.go:94:21: c.fs.NFSClientRPCStats undefined (type procfs.FS has no field or method NFSClientRPCStats) (compile)
collector/bcache_linux.go:52:21: c.fs.BcacheStats undefined (type sysfs.FS has no field or method BcacheStats) (compile)
collector/xfs_linux.go:47:21: c.fs.XFSStats undefined (type sysfs.FS has no field or method XFSStats) (compile)
collector/nfsd_linux.go:60:21: c.fs.NFSdServerRPCStats undefined (type procfs.FS has no field or method NFSdServerRPCStats) (compile)
collector/nfs_linux.go:94:21: c.fs.NFSClientRPCStats undefined (type procfs.FS has no field or method NFSClientRPCStats) (compile)
collector/bcache_linux.go:52:21: c.fs.BcacheStats undefined (type sysfs.FS has no field or method BcacheStats) (compile)
make: *** [Makefile.common:162: common-staticcheck] Error 1

What did you expect to see?

Successful compiling

What did you see instead?

Problems to compile against the latest procfs.

[SuperQ]

We're doing a bunch of refactoring in the procfs library right now. It should be done soon and we'll update the node_exporter's procfs library.

/cc @pgier

[pgier]

Currently waiting for prometheus/procfs#149 to be merged, and then I will create a PR to update node_exporter to use the re-factored API.

[discordianfish]

Hrmm but I don't understand why it fails to build. We should have the right versions vendored.

[SuperQ]

Closed with #1335