Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build tags for collectors #1745

Merged
merged 1 commit into from Jun 14, 2020
Merged

Fix build tags for collectors #1745

merged 1 commit into from Jun 14, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jun 12, 2020

Existing build tags for collectors seems out of sync, and when I try to build for freebsd with build tag noboottime noexec nomeminfo nonetdev nozfs nofilesystem just fails with:

github.com/prometheus/node_exporter/collector/zfs_freebsd.go:24:12: undefined: bsdSysctl
github.com/prometheus/node_exporter/collector/zfs_freebsd.go:38:14: undefined: bsdSysctl

which is not the expected behavior I suppose, because zfs was included even with nozfs tag.

This PR is an attempt to fix collectors' build tags, and once merged, users should be able to build with/without specific collectors with correct build tags.

/cc @SuperQ @discordianfish

Signed-off-by: Jeffrey Stoke <me@arhat.dev>
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup!

@SuperQ SuperQ merged commit 2cefe3d into prometheus:master Jun 14, 2020
@SuperQ SuperQ mentioned this pull request Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant