Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrape (histograms): Implement OpenMetrics histogram experiment #11172

Closed
beorn7 opened this issue Aug 16, 2022 · 3 comments
Closed

scrape (histograms): Implement OpenMetrics histogram experiment #11172

beorn7 opened this issue Aug 16, 2022 · 3 comments

Comments

@beorn7
Copy link
Member

beorn7 commented Aug 16, 2022

OpenObservability/OpenMetrics#247 describes an experiment to embed a preliminary text format into the existing OM text format to gather experience with native histograms as text format.

We need to implement parsing this experimental OM format (behind the native histogram feature flag). Note that this is not meant to be the final format. It is only an easy way to play with a text representation, which will then inform the final text representation.

@beorn7
Copy link
Member Author

beorn7 commented Aug 16, 2022

Also note that this is different from the effort to extend the OM protobuf format for native histograms.

@beorn7
Copy link
Member Author

beorn7 commented Oct 5, 2022

Since @fstab has implemented Native Histogram support in client_java by adding protobuf, the immediate need to hack some kind of support into the OM text format is somewhat diminished.

Furthermore, nobody else approached me about the experiment.

And finally, adding Native Histogram support to the OM protobuf spec seemed relatively straight forward, which gives implementers yet another option.

All of this shouldn't imply that we should drop the experiment, but I think we can demote it to P2 as there are enough options to play with Native Histograms beyond Go.

@beorn7
Copy link
Member Author

beorn7 commented Mar 14, 2023

Given the reaction to a brainstorming doc, I think we should not pursuit the "embedded JSON" idea any longer (but we can, of course, change our minds again). Of all the ideas discussed, "embedded JSON" (idea 1 in the doc) was the least liked, notably also by @csmarchbanks, who maintains client_python, which will probably be the first instrumentation library to implement a text format for native histograms.

Therefore, I'm closing this issue (for now).

@beorn7 beorn7 closed this as completed Mar 14, 2023
@prometheus prometheus locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant