Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to exclude a runner #365

Closed
julianrubisch opened this issue Nov 14, 2019 · 2 comments
Closed

Add option to exclude a runner #365

julianrubisch opened this issue Nov 14, 2019 · 2 comments

Comments

@julianrubisch
Copy link
Contributor

This requires some explanation. IIUC you can specify which runners to run with -r, but pronto will actually use this to require a certain runner.

I wrote a ruby-standardrb runner https://github.com/julianrubisch/pronto-standardrb (see respective PR #364) basically only by subclassing pronto-rubocop (because that's what standard is, an opinionated wrapper around rubocop).

Now of course in that implementation I need to require the rubocop runner: https://github.com/julianrubisch/pronto-standardrb/blob/c5669db79609f4fba40ba04362fe37130ea0f930/lib/pronto/standardrb.rb#L3

which will also load (and thus, run) it and lead to conflicting outputs since the base rubocop configuration is quite different from standard.

so I could basically copy-paste everything from pronto-rubocop and not require it at all, but being all tuned to DRY implementations this really makes me want to tear my hair out...


TL;DR: Runners cannot be easily subclassed.

@ashkulz
Copy link
Member

ashkulz commented Sep 6, 2021

@julianrubisch can you check if the linked PR (which is now merged) solves your problem?

@julianrubisch
Copy link
Contributor Author

does look good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants