You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
which will also load (and thus, run) it and lead to conflicting outputs since the base rubocop configuration is quite different from standard.
so I could basically copy-paste everything from pronto-rubocop and not require it at all, but being all tuned to DRY implementations this really makes me want to tear my hair out...
TL;DR: Runners cannot be easily subclassed.
The text was updated successfully, but these errors were encountered:
This requires some explanation. IIUC you can specify which runners to run with
-r
, but pronto will actually use this torequire
a certain runner.I wrote a
ruby-standardrb
runner https://github.com/julianrubisch/pronto-standardrb (see respective PR #364) basically only by subclassingpronto-rubocop
(because that's whatstandard
is, an opinionated wrapper around rubocop).Now of course in that implementation I need to
require
the rubocop runner: https://github.com/julianrubisch/pronto-standardrb/blob/c5669db79609f4fba40ba04362fe37130ea0f930/lib/pronto/standardrb.rb#L3which will also load (and thus, run) it and lead to conflicting outputs since the base rubocop configuration is quite different from
standard
.so I could basically copy-paste everything from
pronto-rubocop
and not require it at all, but being all tuned to DRY implementations this really makes me want to tear my hair out...TL;DR: Runners cannot be easily subclassed.
The text was updated successfully, but these errors were encountered: