Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(passport): Implement Custom domain support #2194

Closed
5 tasks done
betimshahini opened this issue May 1, 2023 · 1 comment · Fixed by #2330
Closed
5 tasks done

chore(passport): Implement Custom domain support #2194

betimshahini opened this issue May 1, 2023 · 1 comment · Fixed by #2330
Assignees

Comments

@betimshahini
Copy link
Contributor

betimshahini commented May 1, 2023

Implement authentication against configured custom domains

Leverage custom domain details for app from Starbase. Mock data, if needed, based on public app data endpoint schema, assuming it contains custom domain info.

  • The session server strategies inside passport need to take custom domain parameters to secure sessions
  • Cookie strategy to be adjusted to localize the session only to the rollup infra (restrict to registered subdomains)
  • .well-known endpoints need to reflect the custom domain in all URLs
  • ID, access and refresh tokens (but not the authentication tokens) should have the issuer be the custom domain.
  • CSP policies
@szkl
Copy link
Contributor

szkl commented May 25, 2023

The first item is implemented in #2330. The rest looks like already done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants