Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(passport): User able to disconnect the wallet and still sign in using the earlier triggered MetaMask notification #2288

Closed
WinsCodes opened this issue May 15, 2023 · 1 comment · Fixed by #2393
Assignees
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@WinsCodes
Copy link

Description

User is able to disconnect the wallet and still sign in using the earlier triggered MetaMask notification

Steps to Reproduce

  1. Goto 'https://passport-next.rollup.id/authenticate'
  2. Select the option 'Connect with Wallet'
  3. Select 'MetaMask' in the Connect Wallet-pop up
  4. Connect a wallet and once connected click the 'Continue with <wallet_address>' button
  5. Once the 'MetaMask Notification' window is displayed, try disconnecting the wallet and click 'Sign' on the MetaMask notification window.

Expected Behavior

If user is allowed to disconnect the connected wallet then tries Signing in his wallet - he should be notified that his wallet is now disconnected (or the user should not be allowed to disconnect his wallet once he has initiated the Sign in flow)

Actual Behavior

With the MetaMask Notification window still open - user able to disconnect his wallet and even post that sign in and proceed.

@WinsCodes WinsCodes added the bug Indicates an unexpected problem or unintended behavior label May 15, 2023
@maurerbot
Copy link
Contributor

maurerbot commented Jun 12, 2023

You can't go directly to https://passport-next.rollup.id/authenticat directly. You have to go to /authorize endpoint with your client id, etc. Can you confirm this is an issue still?

When going through the flow first with /authorize I am unable to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
5 participants
@maurerbot @betimshahini @poolsar42 @WinsCodes and others