From 0c6e3b32114c87ec684b49cc50b3ccc36d30b6b8 Mon Sep 17 00:00:00 2001 From: Constantin Costescu Date: Sun, 9 Aug 2020 20:13:09 +0200 Subject: [PATCH] Integrate eo iwfy (#332) integrate EO static analyzer iwillfailyou --- .travis.yml | 2 +- README.md | 7 ++ pom.xml | 33 ++++++- .../finapi/account/FpAccountInterface.java | 2 +- .../java/org/proshin/finapi/account/Type.java | 21 ----- .../org/proshin/finapi/account/TypeOf.java | 37 ++++++++ .../org/proshin/finapi/account/in/Debtor.java | 89 +++++++++++++++++++ .../account/in/DirectDebitParameters.java | 68 -------------- .../account/in/MoneyTransferParameters.java | 59 ------------ .../proshin/finapi/account/in/Recipient.java | 78 ++++++++++++++++ .../finapi/bank/out/FpBankInterface.java | 2 +- .../in/ConnectInterfaceParameters.java | 2 +- .../in/ImportBankConnectionParameters.java | 2 +- .../out/FpBankConnectionInterface.java | 2 +- .../bankconnection/out/FpBankConsent.java | 2 +- .../bankconnection/out/FpLoginCredential.java | 2 +- .../finapi/category/in/FpEditParameters.java | 2 +- .../in/TrainCategorizationParameters.java | 65 -------------- .../in/TrainCategorizationTransaction.java | 84 +++++++++++++++++ .../proshin/finapi/endpoint/FpEndpoint.java | 2 + .../proshin/finapi/exception/FinapiError.java | 2 +- .../finapi/exception/FinapiException.java | 2 + .../finapi/exception/NoFieldException.java | 2 + .../org/proshin/finapi/mock/in/Account.java | 2 +- .../org/proshin/finapi/payment/FpPayment.java | 2 +- .../proshin/finapi/payment/FpPayments.java | 2 +- .../finapi/payment/in/FpQueryCriteria.java | 2 +- .../finapi/primitives/IterableJsonArray.java | 1 + .../primitives/MultiStepAuthentication.java | 2 +- .../finapi/primitives/QueryString.java | 2 +- .../optional/OptionalLocalDateOf.java | 2 +- .../tppcertificate/FpTppCertificate.java | 2 +- .../tppcertificate/FpTppCertificates.java | 2 +- .../in/CreateTppCertificateParameters.java | 2 +- .../in/QueryTppCertificatesCriteria.java | 2 +- .../FpTppAuthenticationGroup.java | 2 +- .../FpTppAuthenticationGroups.java | 2 +- .../finapi/tppcredential/FpTppCredential.java | 2 +- .../tppcredential/FpTppCredentials.java | 2 +- .../in/CreateTppCredentialParameters.java | 2 +- .../in/EditTppCredentialParameters.java | 2 +- .../QueryTppAuthenticationGroupsCriteria.java | 2 +- .../in/QueryTppCredentialsCriteria.java | 2 +- .../finapi/TestWithMockedEndpoint.java | 10 +-- .../accesstoken/UserAccessTokenTest.java | 2 +- .../proshin/finapi/account/FpAccountTest.java | 2 +- .../finapi/account/FpAccountsTest.java | 2 +- .../finapi/account/FpDirectDebitTest.java | 5 +- .../finapi/account/FpMoneyTransferTest.java | 7 +- .../org/proshin/finapi/account/TypeTest.java | 6 +- .../out/FpSepaExecutingResponseTest.java | 2 +- .../out/FpSepaRequestingResponseTest.java | 2 +- .../org/proshin/finapi/bank/FpBankTest.java | 2 +- .../bankconnection/FpBankConnectionTest.java | 2 +- .../bankconnection/FpBankConnectionsTest.java | 2 +- .../bankconnection/out/FpBankConsentTest.java | 2 +- .../bankconnection/out/FpOwnerTest.java | 2 +- .../out/FpTwoStepProceduresTest.java | 2 +- .../finapi/category/FpCategoriesTest.java | 5 +- .../finapi/category/FpCategoryTest.java | 2 +- .../finapi/category/out/FpCashFlowTest.java | 3 +- .../proshin/finapi/client/FpClientTest.java | 2 +- .../finapi/exception/FinapiExceptionTest.java | 2 +- .../org/proshin/finapi/fake/FakeRoute.java | 6 +- .../org/proshin/finapi/label/FpLabelTest.java | 3 +- .../org/proshin/finapi/label/LabelsTest.java | 2 +- .../finapi/mandator/FpMandatorTest.java | 2 +- .../mandator/out/FpDeletionResultTest.java | 3 +- .../finapi/mandator/out/FpUserTest.java | 3 +- .../finapi/mock/FpMocksAndTestsTest.java | 2 +- .../mock/out/FpCategorizationResultTest.java | 3 +- .../FpNotificationRuleTest.java | 2 +- .../FpNotificationRulesTest.java | 2 +- .../in/CreatingParametersTest.java | 2 +- .../finapi/payment/FpPaymentsTest.java | 2 +- .../primitives/IterableJsonArrayTest.java | 2 +- .../finapi/primitives/StringOfTest.java | 3 +- .../finapi/primitives/paging/FpPageTest.java | 2 +- .../primitives/paging/FpPagingTest.java | 3 +- .../finapi/security/FpSecuritiesTest.java | 2 +- .../finapi/security/FpSecurityTest.java | 2 +- .../tppcertificate/FpTppCertificateTest.java | 2 +- .../tppcertificate/FpTppCertificatesTest.java | 2 +- .../CreateTppCertificateParametersTest.java | 2 +- .../FpTppAuthenticationGroupTest.java | 2 +- .../tppcredential/FpTppCredentialTest.java | 2 +- .../tppcredential/FpTppCredentialsTest.java | 2 +- .../in/CreateTppCredentialParametersTest.java | 2 +- .../finapi/transaction/FpTransactionTest.java | 2 +- .../transaction/FpTransactionsTest.java | 2 +- .../proshin/finapi/webform/FpWebFormTest.java | 2 +- .../proshin/finapi/webform/WebFormsTest.java | 2 +- 92 files changed, 434 insertions(+), 304 deletions(-) create mode 100644 src/main/java/org/proshin/finapi/account/TypeOf.java create mode 100644 src/main/java/org/proshin/finapi/account/in/Debtor.java create mode 100644 src/main/java/org/proshin/finapi/account/in/Recipient.java create mode 100644 src/main/java/org/proshin/finapi/category/in/TrainCategorizationTransaction.java diff --git a/.travis.yml b/.travis.yml index 8fc2b22..d450edc 100644 --- a/.travis.yml +++ b/.travis.yml @@ -13,7 +13,7 @@ addons: organization: proshin-roman-github install: true script: -- mvn clean org.jacoco:jacoco-maven-plugin:prepare-agent package sonar:sonar +- mvn clean org.jacoco:jacoco-maven-plugin:prepare-agent package iwillfailyou:iwillfailyou sonar:sonar after_success: - mvn coveralls:report - bash <(curl -s https://codecov.io/bash) diff --git a/README.md b/README.md index 6126ddd..4cc1964 100644 --- a/README.md +++ b/README.md @@ -45,6 +45,13 @@ The project is following the next principles (it is a subset of [those ones](htt - No instanceof, type casting or reflection - No implementation inheritance +All badges are through [iwillfailyou](https://iwillfailyou.com/) + +![nullfree status](https://iwillfailyou.com/nullfree/proshin-roman/finapi-java-client) +![staticfree status](https://iwillfailyou.com/staticfree/proshin-roman/finapi-java-client) +![allfinal status](https://iwillfailyou.com/allfinal/proshin-roman/finapi-java-client) +![allpublic status](https://iwillfailyou.com/allpublic/proshin-roman/finapi-java-client) + ## How to use Just add the following lines into your `pom.xml` diff --git a/pom.xml b/pom.xml index 93ccf6a..db1d1f5 100644 --- a/pom.xml +++ b/pom.xml @@ -79,7 +79,7 @@ org.cactoos cactoos - 0.44 + 0.46 org.apache.httpcomponents @@ -265,6 +265,37 @@ true + + + com.iwillfailyou + iwillfailyou-maven-plugin + 0.2.0 + + + + false + + false + 0 + true + + + false + 0 + + + false + 0 + true + true + false + + + false + 0 + + + diff --git a/src/main/java/org/proshin/finapi/account/FpAccountInterface.java b/src/main/java/org/proshin/finapi/account/FpAccountInterface.java index c104ea8..b2ad325 100644 --- a/src/main/java/org/proshin/finapi/account/FpAccountInterface.java +++ b/src/main/java/org/proshin/finapi/account/FpAccountInterface.java @@ -24,7 +24,7 @@ import org.proshin.finapi.primitives.IterableJsonArray; import org.proshin.finapi.primitives.optional.OptionalOffsetDateTimeOf; -public class FpAccountInterface implements AccountInterface { +public final class FpAccountInterface implements AccountInterface { private final JSONObject origin; diff --git a/src/main/java/org/proshin/finapi/account/Type.java b/src/main/java/org/proshin/finapi/account/Type.java index ae59307..616f811 100644 --- a/src/main/java/org/proshin/finapi/account/Type.java +++ b/src/main/java/org/proshin/finapi/account/Type.java @@ -53,25 +53,4 @@ public enum Type { public int asCode() { return this.code; } - - /** - * @deprecated since v0.1.92 due to PSD2-related changes - */ - @Deprecated - public static class TypeOf { - private final int code; - - public TypeOf(final int code) { - this.code = code; - } - - public Type get() { - for (final Type type : values()) { - if (type.asCode() == this.code) { - return type; - } - } - throw new IllegalArgumentException(String.format("Unknown type %d", this.code)); - } - } } diff --git a/src/main/java/org/proshin/finapi/account/TypeOf.java b/src/main/java/org/proshin/finapi/account/TypeOf.java new file mode 100644 index 0000000..74d7130 --- /dev/null +++ b/src/main/java/org/proshin/finapi/account/TypeOf.java @@ -0,0 +1,37 @@ +/* + * Copyright 2020 Roman Proshin + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.proshin.finapi.account; + +/** + * @deprecated since v0.1.92 due to PSD2-related changes + */ +@Deprecated +public final class TypeOf { + private final int code; + + public TypeOf(final int code) { + this.code = code; + } + + public Type get() { + for (final Type type : Type.values()) { + if (type.asCode() == this.code) { + return type; + } + } + throw new IllegalArgumentException(String.format("Unknown type %d", this.code)); + } +} diff --git a/src/main/java/org/proshin/finapi/account/in/Debtor.java b/src/main/java/org/proshin/finapi/account/in/Debtor.java new file mode 100644 index 0000000..e5663c1 --- /dev/null +++ b/src/main/java/org/proshin/finapi/account/in/Debtor.java @@ -0,0 +1,89 @@ +/* + * Copyright 2020 Roman Proshin + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.proshin.finapi.account.in; + +import java.math.BigDecimal; +import java.time.LocalDate; +import org.json.JSONObject; +import org.proshin.finapi.Jsonable; +import org.proshin.finapi.primitives.StringOf; + +public final class Debtor implements Jsonable { + private final JSONObject origin; + + public Debtor() { + this(new JSONObject()); + } + + public Debtor(final JSONObject origin) { + this.origin = origin; + } + + public Debtor withName(final String name) { + this.origin.put("debitorName", name); + return this; + } + + public Debtor withIban(final String iban) { + this.origin.put("debitorIban", iban); + return this; + } + + public Debtor withBic(final String bic) { + this.origin.put("debitorBic", bic); + return this; + } + + public Debtor withAmount(final BigDecimal amount) { + this.origin.put("amount", amount); + return this; + } + + public Debtor withPurpose(final String purpose) { + this.origin.put("purpose", purpose); + return this; + } + + public Debtor withSepaPurposeCode(final String sepaPurposeCode) { + this.origin.put("sepaPurposeCode", sepaPurposeCode); + return this; + } + + public Debtor withMandateId(final String mandateId) { + this.origin.put("mandateId", mandateId); + return this; + } + + public Debtor withMandateDate(final LocalDate mandateDate) { + this.origin.put("mandateDate", new StringOf(mandateDate)); + return this; + } + + public Debtor withCreditorId(final String creditorId) { + this.origin.put("creditorId", creditorId); + return this; + } + + public Debtor withEndToEndId(final String endToEndId) { + this.origin.put("endToEndId", endToEndId); + return this; + } + + @Override + public JSONObject asJson() { + return this.origin; + } +} diff --git a/src/main/java/org/proshin/finapi/account/in/DirectDebitParameters.java b/src/main/java/org/proshin/finapi/account/in/DirectDebitParameters.java index 02f51b4..32d1b9a 100644 --- a/src/main/java/org/proshin/finapi/account/in/DirectDebitParameters.java +++ b/src/main/java/org/proshin/finapi/account/in/DirectDebitParameters.java @@ -15,7 +15,6 @@ */ package org.proshin.finapi.account.in; -import java.math.BigDecimal; import java.time.LocalDate; import org.json.JSONObject; import org.proshin.finapi.Jsonable; @@ -112,71 +111,4 @@ public enum DirectDebitType { public enum SequenceType { OOFF, FRST, RCUR, FNAL } - - public static final class Debtor implements Jsonable { - private final JSONObject origin; - - public Debtor() { - this(new JSONObject()); - } - - public Debtor(final JSONObject origin) { - this.origin = origin; - } - - public Debtor withName(final String name) { - this.origin.put("debitorName", name); - return this; - } - - public Debtor withIban(final String iban) { - this.origin.put("debitorIban", iban); - return this; - } - - public Debtor withBic(final String bic) { - this.origin.put("debitorBic", bic); - return this; - } - - public Debtor withAmount(final BigDecimal amount) { - this.origin.put("amount", amount); - return this; - } - - public Debtor withPurpose(final String purpose) { - this.origin.put("purpose", purpose); - return this; - } - - public Debtor withSepaPurposeCode(final String sepaPurposeCode) { - this.origin.put("sepaPurposeCode", sepaPurposeCode); - return this; - } - - public Debtor withMandateId(final String mandateId) { - this.origin.put("mandateId", mandateId); - return this; - } - - public Debtor withMandateDate(final LocalDate mandateDate) { - this.origin.put("mandateDate", new StringOf(mandateDate)); - return this; - } - - public Debtor withCreditorId(final String creditorId) { - this.origin.put("creditorId", creditorId); - return this; - } - - public Debtor withEndToEndId(final String endToEndId) { - this.origin.put("endToEndId", endToEndId); - return this; - } - - @Override - public JSONObject asJson() { - return this.origin; - } - } } diff --git a/src/main/java/org/proshin/finapi/account/in/MoneyTransferParameters.java b/src/main/java/org/proshin/finapi/account/in/MoneyTransferParameters.java index b6b1247..2c58fda 100644 --- a/src/main/java/org/proshin/finapi/account/in/MoneyTransferParameters.java +++ b/src/main/java/org/proshin/finapi/account/in/MoneyTransferParameters.java @@ -15,7 +15,6 @@ */ package org.proshin.finapi.account.in; -import java.math.BigDecimal; import java.time.LocalDate; import java.util.Iterator; import org.cactoos.iterator.IteratorOf; @@ -112,62 +111,4 @@ public MoneyTransferParameters withMultiStepAuthentication(final MultiStepAuthen public JSONObject asJson() { return this.origin; } - - public static final class Recipient implements Jsonable { - - private final JSONObject origin; - - public Recipient() { - this(new JSONObject()); - } - - public Recipient(final JSONObject origin) { - this.origin = origin; - } - - public Recipient withName(final String name) { - this.origin.put("recipientName", name); - return this; - } - - public Recipient withIban(final String iban) { - this.origin.put("recipientIban", iban); - return this; - } - - public Recipient withBic(final String bic) { - this.origin.put("recipientBic", bic); - return this; - } - - public Recipient withClearingAccount(final String id) { - this.origin.put("clearingAccountId", id); - return this; - } - - public Recipient withEndToEndId(final String endToEndId) { - this.origin.put("endToEndId", endToEndId); - return this; - } - - public Recipient withAmount(final BigDecimal amount) { - this.origin.put("amount", amount); - return this; - } - - public Recipient withPurpose(final String purpose) { - this.origin.put("purpose", purpose); - return this; - } - - public Recipient withSepaPurposeCode(final String sepaPurposeCode) { - this.origin.put("sepaPurposeCode", sepaPurposeCode); - return this; - } - - @Override - public JSONObject asJson() { - return this.origin; - } - } } diff --git a/src/main/java/org/proshin/finapi/account/in/Recipient.java b/src/main/java/org/proshin/finapi/account/in/Recipient.java new file mode 100644 index 0000000..913ecfe --- /dev/null +++ b/src/main/java/org/proshin/finapi/account/in/Recipient.java @@ -0,0 +1,78 @@ +/* + * Copyright 2020 Roman Proshin + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.proshin.finapi.account.in; + +import java.math.BigDecimal; +import org.json.JSONObject; +import org.proshin.finapi.Jsonable; + +public final class Recipient implements Jsonable { + + private final JSONObject origin; + + public Recipient() { + this(new JSONObject()); + } + + public Recipient(final JSONObject origin) { + this.origin = origin; + } + + public Recipient withName(final String name) { + this.origin.put("recipientName", name); + return this; + } + + public Recipient withIban(final String iban) { + this.origin.put("recipientIban", iban); + return this; + } + + public Recipient withBic(final String bic) { + this.origin.put("recipientBic", bic); + return this; + } + + public Recipient withClearingAccount(final String id) { + this.origin.put("clearingAccountId", id); + return this; + } + + public Recipient withEndToEndId(final String endToEndId) { + this.origin.put("endToEndId", endToEndId); + return this; + } + + public Recipient withAmount(final BigDecimal amount) { + this.origin.put("amount", amount); + return this; + } + + public Recipient withPurpose(final String purpose) { + this.origin.put("purpose", purpose); + return this; + } + + public Recipient withSepaPurposeCode(final String sepaPurposeCode) { + this.origin.put("sepaPurposeCode", sepaPurposeCode); + return this; + } + + @Override + public JSONObject asJson() { + return this.origin; + } +} diff --git a/src/main/java/org/proshin/finapi/bank/out/FpBankInterface.java b/src/main/java/org/proshin/finapi/bank/out/FpBankInterface.java index 56f6c38..4523db5 100644 --- a/src/main/java/org/proshin/finapi/bank/out/FpBankInterface.java +++ b/src/main/java/org/proshin/finapi/bank/out/FpBankInterface.java @@ -25,7 +25,7 @@ import org.proshin.finapi.tppcredential.FpTppAuthenticationGroup; import org.proshin.finapi.tppcredential.TppAuthenticationGroup; -public class FpBankInterface implements BankInterface { +public final class FpBankInterface implements BankInterface { private final JSONObject origin; diff --git a/src/main/java/org/proshin/finapi/bankconnection/in/ConnectInterfaceParameters.java b/src/main/java/org/proshin/finapi/bankconnection/in/ConnectInterfaceParameters.java index 9d556ad..9ada6ea 100644 --- a/src/main/java/org/proshin/finapi/bankconnection/in/ConnectInterfaceParameters.java +++ b/src/main/java/org/proshin/finapi/bankconnection/in/ConnectInterfaceParameters.java @@ -21,7 +21,7 @@ import org.proshin.finapi.primitives.BankingInterface; import org.proshin.finapi.primitives.MultiStepAuthentication; -public class ConnectInterfaceParameters implements Jsonable { +public final class ConnectInterfaceParameters implements Jsonable { private final JSONObject origin; diff --git a/src/main/java/org/proshin/finapi/bankconnection/in/ImportBankConnectionParameters.java b/src/main/java/org/proshin/finapi/bankconnection/in/ImportBankConnectionParameters.java index 01593c9..e526b34 100644 --- a/src/main/java/org/proshin/finapi/bankconnection/in/ImportBankConnectionParameters.java +++ b/src/main/java/org/proshin/finapi/bankconnection/in/ImportBankConnectionParameters.java @@ -16,7 +16,7 @@ package org.proshin.finapi.bankconnection.in; import java.util.Map; -import org.cactoos.collection.Mapped; +import org.cactoos.list.Mapped; import org.json.JSONObject; import org.proshin.finapi.Jsonable; import org.proshin.finapi.account.Type; diff --git a/src/main/java/org/proshin/finapi/bankconnection/out/FpBankConnectionInterface.java b/src/main/java/org/proshin/finapi/bankconnection/out/FpBankConnectionInterface.java index 46f0d85..80c65c7 100644 --- a/src/main/java/org/proshin/finapi/bankconnection/out/FpBankConnectionInterface.java +++ b/src/main/java/org/proshin/finapi/bankconnection/out/FpBankConnectionInterface.java @@ -21,7 +21,7 @@ import org.proshin.finapi.primitives.IterableJsonArray; import org.proshin.finapi.primitives.optional.OptionalObjectOf; -public class FpBankConnectionInterface implements BankConnectionInterface { +public final class FpBankConnectionInterface implements BankConnectionInterface { private final JSONObject origin; diff --git a/src/main/java/org/proshin/finapi/bankconnection/out/FpBankConsent.java b/src/main/java/org/proshin/finapi/bankconnection/out/FpBankConsent.java index 85154c7..01d750d 100644 --- a/src/main/java/org/proshin/finapi/bankconnection/out/FpBankConsent.java +++ b/src/main/java/org/proshin/finapi/bankconnection/out/FpBankConsent.java @@ -19,7 +19,7 @@ import org.json.JSONObject; import org.proshin.finapi.primitives.OffsetDateTimeOf; -public class FpBankConsent implements BankConsent { +public final class FpBankConsent implements BankConsent { private final JSONObject origin; diff --git a/src/main/java/org/proshin/finapi/bankconnection/out/FpLoginCredential.java b/src/main/java/org/proshin/finapi/bankconnection/out/FpLoginCredential.java index cc2a8ec..5a408cd 100644 --- a/src/main/java/org/proshin/finapi/bankconnection/out/FpLoginCredential.java +++ b/src/main/java/org/proshin/finapi/bankconnection/out/FpLoginCredential.java @@ -19,7 +19,7 @@ import org.json.JSONObject; import org.proshin.finapi.primitives.optional.OptionalStringOf; -public class FpLoginCredential implements LoginCredential { +public final class FpLoginCredential implements LoginCredential { private final JSONObject origin; diff --git a/src/main/java/org/proshin/finapi/category/in/FpEditParameters.java b/src/main/java/org/proshin/finapi/category/in/FpEditParameters.java index 3021f43..67bf53f 100644 --- a/src/main/java/org/proshin/finapi/category/in/FpEditParameters.java +++ b/src/main/java/org/proshin/finapi/category/in/FpEditParameters.java @@ -18,7 +18,7 @@ import org.json.JSONObject; import org.proshin.finapi.Jsonable; -public class FpEditParameters implements Jsonable { +public final class FpEditParameters implements Jsonable { private final JSONObject origin; diff --git a/src/main/java/org/proshin/finapi/category/in/TrainCategorizationParameters.java b/src/main/java/org/proshin/finapi/category/in/TrainCategorizationParameters.java index d13e2e6..e32c2ec 100644 --- a/src/main/java/org/proshin/finapi/category/in/TrainCategorizationParameters.java +++ b/src/main/java/org/proshin/finapi/category/in/TrainCategorizationParameters.java @@ -15,13 +15,11 @@ */ package org.proshin.finapi.category.in; -import java.math.BigDecimal; import java.util.Arrays; import java.util.stream.Collectors; import org.json.JSONArray; import org.json.JSONObject; import org.proshin.finapi.Jsonable; -import org.proshin.finapi.account.Type; public final class TrainCategorizationParameters implements Jsonable { @@ -56,67 +54,4 @@ public TrainCategorizationParameters withCategory(final Long category) { public JSONObject asJson() { return this.origin; } - - public static final class TrainCategorizationTransaction implements Jsonable { - - private final JSONObject origin; - - public TrainCategorizationTransaction() { - this(new JSONObject()); - } - - public TrainCategorizationTransaction(final JSONObject origin) { - this.origin = origin; - } - - public TrainCategorizationTransaction withAccountType(final Type type) { - this.origin.put("accountTypeId", type.asCode()); - return this; - } - - public TrainCategorizationTransaction withAmount(final BigDecimal amount) { - this.origin.put("amount", amount); - return this; - } - - public TrainCategorizationTransaction withPurpose(final String purpose) { - this.origin.put("purpose", purpose); - return this; - } - - public TrainCategorizationTransaction withCounterpart(final String counterpart) { - this.origin.put("counterpart", counterpart); - return this; - } - - public TrainCategorizationTransaction withCounterpartIban(final String counterpartIban) { - this.origin.put("counterpartIban", counterpartIban); - return this; - } - - public TrainCategorizationTransaction withCounterpartAccountNumber(final String counterpartAccountNumber) { - this.origin.put("counterpartAccountNumber", counterpartAccountNumber); - return this; - } - - public TrainCategorizationTransaction withCounterpartBlz(final String counterpartBlz) { - this.origin.put("counterpartBlz", counterpartBlz); - return this; - } - - public TrainCategorizationTransaction withCounterpartBic(final String counterpartBic) { - this.origin.put("counterpartBic", counterpartBic); - return this; - } - - public TrainCategorizationTransaction withMcCode(final String mcCode) { - this.origin.put("mcCode", mcCode); - return this; - } - - @Override - public JSONObject asJson() { - return this.origin; - } - } } diff --git a/src/main/java/org/proshin/finapi/category/in/TrainCategorizationTransaction.java b/src/main/java/org/proshin/finapi/category/in/TrainCategorizationTransaction.java new file mode 100644 index 0000000..60208c2 --- /dev/null +++ b/src/main/java/org/proshin/finapi/category/in/TrainCategorizationTransaction.java @@ -0,0 +1,84 @@ +/* + * Copyright 2020 Roman Proshin + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.proshin.finapi.category.in; + +import java.math.BigDecimal; +import org.json.JSONObject; +import org.proshin.finapi.Jsonable; +import org.proshin.finapi.account.Type; + +public final class TrainCategorizationTransaction implements Jsonable { + + private final JSONObject origin; + + public TrainCategorizationTransaction() { + this(new JSONObject()); + } + + public TrainCategorizationTransaction(final JSONObject origin) { + this.origin = origin; + } + + public TrainCategorizationTransaction withAccountType(final Type type) { + this.origin.put("accountTypeId", type.asCode()); + return this; + } + + public TrainCategorizationTransaction withAmount(final BigDecimal amount) { + this.origin.put("amount", amount); + return this; + } + + public TrainCategorizationTransaction withPurpose(final String purpose) { + this.origin.put("purpose", purpose); + return this; + } + + public TrainCategorizationTransaction withCounterpart(final String counterpart) { + this.origin.put("counterpart", counterpart); + return this; + } + + public TrainCategorizationTransaction withCounterpartIban(final String counterpartIban) { + this.origin.put("counterpartIban", counterpartIban); + return this; + } + + public TrainCategorizationTransaction withCounterpartAccountNumber(final String counterpartAccountNumber) { + this.origin.put("counterpartAccountNumber", counterpartAccountNumber); + return this; + } + + public TrainCategorizationTransaction withCounterpartBlz(final String counterpartBlz) { + this.origin.put("counterpartBlz", counterpartBlz); + return this; + } + + public TrainCategorizationTransaction withCounterpartBic(final String counterpartBic) { + this.origin.put("counterpartBic", counterpartBic); + return this; + } + + public TrainCategorizationTransaction withMcCode(final String mcCode) { + this.origin.put("mcCode", mcCode); + return this; + } + + @Override + public JSONObject asJson() { + return this.origin; + } +} diff --git a/src/main/java/org/proshin/finapi/endpoint/FpEndpoint.java b/src/main/java/org/proshin/finapi/endpoint/FpEndpoint.java index e41bac9..8b18907 100644 --- a/src/main/java/org/proshin/finapi/endpoint/FpEndpoint.java +++ b/src/main/java/org/proshin/finapi/endpoint/FpEndpoint.java @@ -49,6 +49,7 @@ public final class FpEndpoint implements Endpoint { + @SuppressWarnings("staticfree") private static final Logger LOGGER = LoggerFactory.getLogger(FpEndpoint.class); private final HttpClient client; @@ -256,6 +257,7 @@ public String patch(final String path, final AccessToken token, final Jsonable b ); } + @SuppressWarnings("staticfree") private static final class AuthorizationHeader implements Header { private final String token; diff --git a/src/main/java/org/proshin/finapi/exception/FinapiError.java b/src/main/java/org/proshin/finapi/exception/FinapiError.java index dd82a9a..c091b3c 100644 --- a/src/main/java/org/proshin/finapi/exception/FinapiError.java +++ b/src/main/java/org/proshin/finapi/exception/FinapiError.java @@ -18,7 +18,7 @@ import java.util.Optional; import org.json.JSONObject; -public class FinapiError { +public final class FinapiError { private final JSONObject origin; diff --git a/src/main/java/org/proshin/finapi/exception/FinapiException.java b/src/main/java/org/proshin/finapi/exception/FinapiException.java index 4eecd44..4d4a023 100644 --- a/src/main/java/org/proshin/finapi/exception/FinapiException.java +++ b/src/main/java/org/proshin/finapi/exception/FinapiException.java @@ -30,6 +30,7 @@ public final class FinapiException extends RuntimeException { + @SuppressWarnings("staticfree") private static final long serialVersionUID = -5608855544688297953L; @SuppressWarnings("TransientFieldNotInitialized") @@ -37,6 +38,7 @@ public final class FinapiException extends RuntimeException { @SuppressWarnings({"TransientFieldNotInitialized", "OptionalUsedAsFieldOrParameterType"}) private final transient Optional location; + @SuppressWarnings("nullfree") public FinapiException(final int expected, final HttpResponse response) { this( String.format( diff --git a/src/main/java/org/proshin/finapi/exception/NoFieldException.java b/src/main/java/org/proshin/finapi/exception/NoFieldException.java index d97e10c..c142061 100644 --- a/src/main/java/org/proshin/finapi/exception/NoFieldException.java +++ b/src/main/java/org/proshin/finapi/exception/NoFieldException.java @@ -16,6 +16,8 @@ package org.proshin.finapi.exception; public final class NoFieldException extends RuntimeException { + + @SuppressWarnings("staticfree") private static final long serialVersionUID = 260448112051805868L; public NoFieldException(final String message) { diff --git a/src/main/java/org/proshin/finapi/mock/in/Account.java b/src/main/java/org/proshin/finapi/mock/in/Account.java index d0d7849..c7e19fe 100644 --- a/src/main/java/org/proshin/finapi/mock/in/Account.java +++ b/src/main/java/org/proshin/finapi/mock/in/Account.java @@ -22,7 +22,7 @@ import org.json.JSONObject; import org.proshin.finapi.Jsonable; -public class Account implements Jsonable { +public final class Account implements Jsonable { private final Supplier origin; diff --git a/src/main/java/org/proshin/finapi/payment/FpPayment.java b/src/main/java/org/proshin/finapi/payment/FpPayment.java index 60625fd..2cca8b0 100644 --- a/src/main/java/org/proshin/finapi/payment/FpPayment.java +++ b/src/main/java/org/proshin/finapi/payment/FpPayment.java @@ -25,7 +25,7 @@ import org.proshin.finapi.primitives.optional.OptionalOf; import org.proshin.finapi.primitives.optional.OptionalOffsetDateTimeOf; -public class FpPayment implements Payment { +public final class FpPayment implements Payment { private final JSONObject origin; diff --git a/src/main/java/org/proshin/finapi/payment/FpPayments.java b/src/main/java/org/proshin/finapi/payment/FpPayments.java index 9462e78..3db5a35 100644 --- a/src/main/java/org/proshin/finapi/payment/FpPayments.java +++ b/src/main/java/org/proshin/finapi/payment/FpPayments.java @@ -22,7 +22,7 @@ import org.proshin.finapi.primitives.paging.FpPage; import org.proshin.finapi.primitives.paging.Page; -public class FpPayments implements Payments { +public final class FpPayments implements Payments { private final Endpoint endpoint; private final AccessToken token; diff --git a/src/main/java/org/proshin/finapi/payment/in/FpQueryCriteria.java b/src/main/java/org/proshin/finapi/payment/in/FpQueryCriteria.java index 866e1ac..9914588 100644 --- a/src/main/java/org/proshin/finapi/payment/in/FpQueryCriteria.java +++ b/src/main/java/org/proshin/finapi/payment/in/FpQueryCriteria.java @@ -25,7 +25,7 @@ import org.proshin.finapi.primitives.pair.CommaSeparatedPair; import org.proshin.finapi.primitives.pair.UrlEncodedPair; -public class FpQueryCriteria implements Iterable { +public final class FpQueryCriteria implements Iterable { private final List pairs; diff --git a/src/main/java/org/proshin/finapi/primitives/IterableJsonArray.java b/src/main/java/org/proshin/finapi/primitives/IterableJsonArray.java index 8fe4f14..4302410 100644 --- a/src/main/java/org/proshin/finapi/primitives/IterableJsonArray.java +++ b/src/main/java/org/proshin/finapi/primitives/IterableJsonArray.java @@ -36,6 +36,7 @@ public Iterator iterator() { return new JsonArrayIterator<>(this.array, this.func); } + @SuppressWarnings("staticfree") private static final class JsonArrayIterator implements Iterator { private final AtomicInteger index; diff --git a/src/main/java/org/proshin/finapi/primitives/MultiStepAuthentication.java b/src/main/java/org/proshin/finapi/primitives/MultiStepAuthentication.java index ac2f50c..6d72e43 100644 --- a/src/main/java/org/proshin/finapi/primitives/MultiStepAuthentication.java +++ b/src/main/java/org/proshin/finapi/primitives/MultiStepAuthentication.java @@ -18,7 +18,7 @@ import org.json.JSONObject; import org.proshin.finapi.Jsonable; -public class MultiStepAuthentication implements Jsonable { +public final class MultiStepAuthentication implements Jsonable { private final JSONObject origin; diff --git a/src/main/java/org/proshin/finapi/primitives/QueryString.java b/src/main/java/org/proshin/finapi/primitives/QueryString.java index d55164c..539e426 100644 --- a/src/main/java/org/proshin/finapi/primitives/QueryString.java +++ b/src/main/java/org/proshin/finapi/primitives/QueryString.java @@ -22,7 +22,7 @@ import org.cactoos.text.Joined; import org.cactoos.text.UncheckedText; -public class QueryString implements Supplier { +public final class QueryString implements Supplier { private final Supplier origin; diff --git a/src/main/java/org/proshin/finapi/primitives/optional/OptionalLocalDateOf.java b/src/main/java/org/proshin/finapi/primitives/optional/OptionalLocalDateOf.java index 495a998..804ecb7 100644 --- a/src/main/java/org/proshin/finapi/primitives/optional/OptionalLocalDateOf.java +++ b/src/main/java/org/proshin/finapi/primitives/optional/OptionalLocalDateOf.java @@ -21,7 +21,7 @@ import org.json.JSONObject; import org.proshin.finapi.primitives.LocalDateOf; -public class OptionalLocalDateOf implements Supplier> { +public final class OptionalLocalDateOf implements Supplier> { private final Supplier> origin; diff --git a/src/main/java/org/proshin/finapi/tppcertificate/FpTppCertificate.java b/src/main/java/org/proshin/finapi/tppcertificate/FpTppCertificate.java index 0d28374..cfa3bad 100644 --- a/src/main/java/org/proshin/finapi/tppcertificate/FpTppCertificate.java +++ b/src/main/java/org/proshin/finapi/tppcertificate/FpTppCertificate.java @@ -23,7 +23,7 @@ import org.proshin.finapi.primitives.optional.OptionalLocalDateOf; import org.proshin.finapi.primitives.optional.OptionalStringOf; -public class FpTppCertificate implements TppCertificate { +public final class FpTppCertificate implements TppCertificate { private final Endpoint endpoint; private final AccessToken token; diff --git a/src/main/java/org/proshin/finapi/tppcertificate/FpTppCertificates.java b/src/main/java/org/proshin/finapi/tppcertificate/FpTppCertificates.java index 8ff978c..5070908 100644 --- a/src/main/java/org/proshin/finapi/tppcertificate/FpTppCertificates.java +++ b/src/main/java/org/proshin/finapi/tppcertificate/FpTppCertificates.java @@ -24,7 +24,7 @@ import org.proshin.finapi.tppcertificate.in.CreateTppCertificateParameters; import org.proshin.finapi.tppcertificate.in.QueryTppCertificatesCriteria; -public class FpTppCertificates implements TppCertificates { +public final class FpTppCertificates implements TppCertificates { private final Endpoint endpoint; private final AccessToken token; diff --git a/src/main/java/org/proshin/finapi/tppcertificate/in/CreateTppCertificateParameters.java b/src/main/java/org/proshin/finapi/tppcertificate/in/CreateTppCertificateParameters.java index c77115a..8dbc470 100644 --- a/src/main/java/org/proshin/finapi/tppcertificate/in/CreateTppCertificateParameters.java +++ b/src/main/java/org/proshin/finapi/tppcertificate/in/CreateTppCertificateParameters.java @@ -21,7 +21,7 @@ import org.proshin.finapi.primitives.StringOf; import org.proshin.finapi.tppcertificate.CertificateType; -public class CreateTppCertificateParameters implements Jsonable { +public final class CreateTppCertificateParameters implements Jsonable { private final JSONObject origin; diff --git a/src/main/java/org/proshin/finapi/tppcertificate/in/QueryTppCertificatesCriteria.java b/src/main/java/org/proshin/finapi/tppcertificate/in/QueryTppCertificatesCriteria.java index 6c4375a..f1b1dd7 100644 --- a/src/main/java/org/proshin/finapi/tppcertificate/in/QueryTppCertificatesCriteria.java +++ b/src/main/java/org/proshin/finapi/tppcertificate/in/QueryTppCertificatesCriteria.java @@ -22,7 +22,7 @@ import org.apache.http.NameValuePair; import org.proshin.finapi.primitives.pair.UrlEncodedPair; -public class QueryTppCertificatesCriteria implements Iterable { +public final class QueryTppCertificatesCriteria implements Iterable { private final List pairs; diff --git a/src/main/java/org/proshin/finapi/tppcredential/FpTppAuthenticationGroup.java b/src/main/java/org/proshin/finapi/tppcredential/FpTppAuthenticationGroup.java index ff00de6..a454968 100644 --- a/src/main/java/org/proshin/finapi/tppcredential/FpTppAuthenticationGroup.java +++ b/src/main/java/org/proshin/finapi/tppcredential/FpTppAuthenticationGroup.java @@ -17,7 +17,7 @@ import org.json.JSONObject; -public class FpTppAuthenticationGroup implements TppAuthenticationGroup { +public final class FpTppAuthenticationGroup implements TppAuthenticationGroup { private final JSONObject origin; diff --git a/src/main/java/org/proshin/finapi/tppcredential/FpTppAuthenticationGroups.java b/src/main/java/org/proshin/finapi/tppcredential/FpTppAuthenticationGroups.java index 04e64bf..b3d5881 100644 --- a/src/main/java/org/proshin/finapi/tppcredential/FpTppAuthenticationGroups.java +++ b/src/main/java/org/proshin/finapi/tppcredential/FpTppAuthenticationGroups.java @@ -22,7 +22,7 @@ import org.proshin.finapi.primitives.paging.Page; import org.proshin.finapi.tppcredential.in.QueryTppAuthenticationGroupsCriteria; -public class FpTppAuthenticationGroups implements TppAuthenticationGroups { +public final class FpTppAuthenticationGroups implements TppAuthenticationGroups { private final Endpoint endpoint; private final AccessToken token; diff --git a/src/main/java/org/proshin/finapi/tppcredential/FpTppCredential.java b/src/main/java/org/proshin/finapi/tppcredential/FpTppCredential.java index e181513..bdc3626 100644 --- a/src/main/java/org/proshin/finapi/tppcredential/FpTppCredential.java +++ b/src/main/java/org/proshin/finapi/tppcredential/FpTppCredential.java @@ -24,7 +24,7 @@ import org.proshin.finapi.primitives.optional.OptionalStringOf; import org.proshin.finapi.tppcredential.in.EditTppCredentialParameters; -public class FpTppCredential implements TppCredential { +public final class FpTppCredential implements TppCredential { private final Endpoint endpoint; private final AccessToken token; diff --git a/src/main/java/org/proshin/finapi/tppcredential/FpTppCredentials.java b/src/main/java/org/proshin/finapi/tppcredential/FpTppCredentials.java index 0bc97e5..fcb5524 100644 --- a/src/main/java/org/proshin/finapi/tppcredential/FpTppCredentials.java +++ b/src/main/java/org/proshin/finapi/tppcredential/FpTppCredentials.java @@ -24,7 +24,7 @@ import org.proshin.finapi.tppcredential.in.CreateTppCredentialParameters; import org.proshin.finapi.tppcredential.in.QueryTppCredentialsCriteria; -public class FpTppCredentials implements TppCredentials { +public final class FpTppCredentials implements TppCredentials { private final Endpoint endpoint; private final AccessToken token; diff --git a/src/main/java/org/proshin/finapi/tppcredential/in/CreateTppCredentialParameters.java b/src/main/java/org/proshin/finapi/tppcredential/in/CreateTppCredentialParameters.java index 68efdeb..63b6b91 100644 --- a/src/main/java/org/proshin/finapi/tppcredential/in/CreateTppCredentialParameters.java +++ b/src/main/java/org/proshin/finapi/tppcredential/in/CreateTppCredentialParameters.java @@ -20,7 +20,7 @@ import org.proshin.finapi.Jsonable; import org.proshin.finapi.primitives.StringOf; -public class CreateTppCredentialParameters implements Jsonable { +public final class CreateTppCredentialParameters implements Jsonable { private final JSONObject origin; diff --git a/src/main/java/org/proshin/finapi/tppcredential/in/EditTppCredentialParameters.java b/src/main/java/org/proshin/finapi/tppcredential/in/EditTppCredentialParameters.java index 255521a..055df38 100644 --- a/src/main/java/org/proshin/finapi/tppcredential/in/EditTppCredentialParameters.java +++ b/src/main/java/org/proshin/finapi/tppcredential/in/EditTppCredentialParameters.java @@ -20,7 +20,7 @@ import org.proshin.finapi.Jsonable; import org.proshin.finapi.primitives.StringOf; -public class EditTppCredentialParameters implements Jsonable { +public final class EditTppCredentialParameters implements Jsonable { private final JSONObject origin; diff --git a/src/main/java/org/proshin/finapi/tppcredential/in/QueryTppAuthenticationGroupsCriteria.java b/src/main/java/org/proshin/finapi/tppcredential/in/QueryTppAuthenticationGroupsCriteria.java index 63d0a8c..14725f3 100644 --- a/src/main/java/org/proshin/finapi/tppcredential/in/QueryTppAuthenticationGroupsCriteria.java +++ b/src/main/java/org/proshin/finapi/tppcredential/in/QueryTppAuthenticationGroupsCriteria.java @@ -22,7 +22,7 @@ import org.apache.http.NameValuePair; import org.proshin.finapi.primitives.pair.UrlEncodedPair; -public class QueryTppAuthenticationGroupsCriteria implements Iterable { +public final class QueryTppAuthenticationGroupsCriteria implements Iterable { private final List pairs; diff --git a/src/main/java/org/proshin/finapi/tppcredential/in/QueryTppCredentialsCriteria.java b/src/main/java/org/proshin/finapi/tppcredential/in/QueryTppCredentialsCriteria.java index bd1478d..20e8d5a 100644 --- a/src/main/java/org/proshin/finapi/tppcredential/in/QueryTppCredentialsCriteria.java +++ b/src/main/java/org/proshin/finapi/tppcredential/in/QueryTppCredentialsCriteria.java @@ -22,7 +22,7 @@ import org.apache.http.NameValuePair; import org.proshin.finapi.primitives.pair.UrlEncodedPair; -public class QueryTppCredentialsCriteria implements Iterable { +public final class QueryTppCredentialsCriteria implements Iterable { private final List pairs; diff --git a/src/test/java/org/proshin/finapi/TestWithMockedEndpoint.java b/src/test/java/org/proshin/finapi/TestWithMockedEndpoint.java index f7d5a82..31f65d6 100644 --- a/src/test/java/org/proshin/finapi/TestWithMockedEndpoint.java +++ b/src/test/java/org/proshin/finapi/TestWithMockedEndpoint.java @@ -23,13 +23,13 @@ import org.proshin.finapi.endpoint.Endpoint; import org.proshin.finapi.endpoint.FpEndpoint; -@SuppressWarnings("AbstractClassWithoutAbstractMethods") @ExtendWith(MockServerExtension.class) +@SuppressWarnings({"AbstractClassWithoutAbstractMethods", "allfinal"}) public abstract class TestWithMockedEndpoint { - @SuppressWarnings("InstanceVariableMayNotBeInitialized") + @SuppressWarnings({"InstanceVariableMayNotBeInitialized", "allfinal"}) private MockServerClient server; - @SuppressWarnings("InstanceVariableMayNotBeInitialized") + @SuppressWarnings({"InstanceVariableMayNotBeInitialized", "allfinal"}) private Endpoint endpoint; @BeforeEach @@ -38,11 +38,11 @@ public void init(@Nonnull final MockServerClient server) { this.endpoint = new FpEndpoint("http://localhost:" + this.server.remoteAddress().getPort()); } - protected Endpoint endpoint() { + public Endpoint endpoint() { return this.endpoint; } - protected MockServerClient server() { + public MockServerClient server() { return this.server; } } diff --git a/src/test/java/org/proshin/finapi/accesstoken/UserAccessTokenTest.java b/src/test/java/org/proshin/finapi/accesstoken/UserAccessTokenTest.java index 3b560f5..031284d 100644 --- a/src/test/java/org/proshin/finapi/accesstoken/UserAccessTokenTest.java +++ b/src/test/java/org/proshin/finapi/accesstoken/UserAccessTokenTest.java @@ -5,7 +5,7 @@ import org.junit.jupiter.api.Test; import org.proshin.finapi.exception.NoFieldException; -public class UserAccessTokenTest { +public final class UserAccessTokenTest { @Test public void testThatUserTokenFailsIfNoRefreshTokenIsSent() { diff --git a/src/test/java/org/proshin/finapi/account/FpAccountTest.java b/src/test/java/org/proshin/finapi/account/FpAccountTest.java index c76b4ec..9dcfd5d 100644 --- a/src/test/java/org/proshin/finapi/account/FpAccountTest.java +++ b/src/test/java/org/proshin/finapi/account/FpAccountTest.java @@ -28,7 +28,7 @@ import org.proshin.finapi.primitives.BankingInterface; import org.proshin.finapi.primitives.OffsetDateTimeOf; -public class FpAccountTest extends TestWithMockedEndpoint { +public final class FpAccountTest extends TestWithMockedEndpoint { @Test public void testFields() { diff --git a/src/test/java/org/proshin/finapi/account/FpAccountsTest.java b/src/test/java/org/proshin/finapi/account/FpAccountsTest.java index ef6307c..95025b2 100644 --- a/src/test/java/org/proshin/finapi/account/FpAccountsTest.java +++ b/src/test/java/org/proshin/finapi/account/FpAccountsTest.java @@ -26,7 +26,7 @@ import org.proshin.finapi.fake.FakeAccessToken; import org.proshin.finapi.primitives.OffsetDateTimeOf; -public class FpAccountsTest extends TestWithMockedEndpoint { +public final class FpAccountsTest extends TestWithMockedEndpoint { @Test public void testOne() { diff --git a/src/test/java/org/proshin/finapi/account/FpDirectDebitTest.java b/src/test/java/org/proshin/finapi/account/FpDirectDebitTest.java index b0f0888..3218fe0 100644 --- a/src/test/java/org/proshin/finapi/account/FpDirectDebitTest.java +++ b/src/test/java/org/proshin/finapi/account/FpDirectDebitTest.java @@ -21,11 +21,12 @@ import org.mockserver.model.HttpResponse; import org.mockserver.model.JsonBody; import org.proshin.finapi.TestWithMockedEndpoint; +import org.proshin.finapi.account.in.Debtor; import org.proshin.finapi.account.in.DirectDebitParameters; import org.proshin.finapi.fake.FakeAccessToken; import org.proshin.finapi.primitives.LocalDateOf; -public class FpDirectDebitTest extends TestWithMockedEndpoint { +public final class FpDirectDebitTest extends TestWithMockedEndpoint { @Test public void testRequest() { @@ -75,7 +76,7 @@ public void testRequest() { .withExecutionDate(new LocalDateOf("2018-01-01").get()) .asSingleBooking() .withDebtors( - new DirectDebitParameters.Debtor() + new Debtor() .withName("Debitor") .withIban("DE13700800000061110500") .withBic("DRESDEFF700") diff --git a/src/test/java/org/proshin/finapi/account/FpMoneyTransferTest.java b/src/test/java/org/proshin/finapi/account/FpMoneyTransferTest.java index c2ea729..767d0c7 100644 --- a/src/test/java/org/proshin/finapi/account/FpMoneyTransferTest.java +++ b/src/test/java/org/proshin/finapi/account/FpMoneyTransferTest.java @@ -22,11 +22,12 @@ import org.mockserver.model.JsonBody; import org.proshin.finapi.TestWithMockedEndpoint; import org.proshin.finapi.account.in.MoneyTransferParameters; +import org.proshin.finapi.account.in.Recipient; import org.proshin.finapi.account.out.SepaRequestingResponse; import org.proshin.finapi.fake.FakeAccessToken; import org.proshin.finapi.primitives.LocalDateOf; -public class FpMoneyTransferTest extends TestWithMockedEndpoint { +public final class FpMoneyTransferTest extends TestWithMockedEndpoint { @Test public void testRequest() { @@ -80,7 +81,7 @@ public void testRequest() { .withExecutionDate(new LocalDateOf("2019-04-03").get()) .asSingleBooking() .withRecipients( - new MoneyTransferParameters.Recipient() + new Recipient() .withName("Recipient #1") .withIban("DE13700800000061110500") .withBic("DRESDEFF700") @@ -88,7 +89,7 @@ public void testRequest() { .withAmount(new BigDecimal("123.45")) .withPurpose("Test Payment #1") .withSepaPurposeCode("OTHR1"), - new MoneyTransferParameters.Recipient() + new Recipient() .withName("Recipient #2") .withIban("DE13700800000061110501") .withBic("DRESDEFF701") diff --git a/src/test/java/org/proshin/finapi/account/TypeTest.java b/src/test/java/org/proshin/finapi/account/TypeTest.java index a375ad6..99d0ead 100644 --- a/src/test/java/org/proshin/finapi/account/TypeTest.java +++ b/src/test/java/org/proshin/finapi/account/TypeTest.java @@ -22,20 +22,20 @@ import org.junit.jupiter.params.provider.CsvSource; import org.junit.jupiter.params.provider.ValueSource; -public class TypeTest { +public final class TypeTest { @ParameterizedTest @CsvSource({"1, Checking", "2, Savings", "3, CreditCard", "4, Security", "5, Loan", "6, Pocket", "7, Membership", "8, Bausparen" }) public void testCorrectTypes(final int typeCode, @Nonnull final Type expectedType) { - assertThat(new Type.TypeOf(typeCode).get()).isEqualTo(expectedType); + assertThat(new TypeOf(typeCode).get()).isEqualTo(expectedType); } @ParameterizedTest @ValueSource(ints = {0, -1, 9, 10, 100}) public void testIllegalCode(final int typeCode) { assertThatExceptionOfType(IllegalArgumentException.class) - .isThrownBy(() -> new Type.TypeOf(typeCode).get()); + .isThrownBy(() -> new TypeOf(typeCode).get()); } } diff --git a/src/test/java/org/proshin/finapi/account/out/FpSepaExecutingResponseTest.java b/src/test/java/org/proshin/finapi/account/out/FpSepaExecutingResponseTest.java index 81e5914..f049f2a 100644 --- a/src/test/java/org/proshin/finapi/account/out/FpSepaExecutingResponseTest.java +++ b/src/test/java/org/proshin/finapi/account/out/FpSepaExecutingResponseTest.java @@ -20,7 +20,7 @@ import org.json.JSONObject; import org.junit.jupiter.api.Test; -public class FpSepaExecutingResponseTest { +public final class FpSepaExecutingResponseTest { @Test public void test() { diff --git a/src/test/java/org/proshin/finapi/account/out/FpSepaRequestingResponseTest.java b/src/test/java/org/proshin/finapi/account/out/FpSepaRequestingResponseTest.java index 8d3a009..8e30621 100644 --- a/src/test/java/org/proshin/finapi/account/out/FpSepaRequestingResponseTest.java +++ b/src/test/java/org/proshin/finapi/account/out/FpSepaRequestingResponseTest.java @@ -20,7 +20,7 @@ import org.json.JSONObject; import org.junit.jupiter.api.Test; -public class FpSepaRequestingResponseTest { +public final class FpSepaRequestingResponseTest { @Test public void test() { diff --git a/src/test/java/org/proshin/finapi/bank/FpBankTest.java b/src/test/java/org/proshin/finapi/bank/FpBankTest.java index 11851d1..ff0e2d6 100644 --- a/src/test/java/org/proshin/finapi/bank/FpBankTest.java +++ b/src/test/java/org/proshin/finapi/bank/FpBankTest.java @@ -29,7 +29,7 @@ import org.proshin.finapi.primitives.OffsetDateTimeOf; import org.proshin.finapi.tppcredential.TppAuthenticationGroup; -public class FpBankTest { +public final class FpBankTest { @Test public void test() { diff --git a/src/test/java/org/proshin/finapi/bankconnection/FpBankConnectionTest.java b/src/test/java/org/proshin/finapi/bankconnection/FpBankConnectionTest.java index 1b44e56..1955038 100644 --- a/src/test/java/org/proshin/finapi/bankconnection/FpBankConnectionTest.java +++ b/src/test/java/org/proshin/finapi/bankconnection/FpBankConnectionTest.java @@ -36,7 +36,7 @@ import org.proshin.finapi.primitives.BankingInterface; import org.proshin.finapi.primitives.OffsetDateTimeOf; -public class FpBankConnectionTest extends TestWithMockedEndpoint { +public final class FpBankConnectionTest extends TestWithMockedEndpoint { @Test public void testParsingJsonStructure() { diff --git a/src/test/java/org/proshin/finapi/bankconnection/FpBankConnectionsTest.java b/src/test/java/org/proshin/finapi/bankconnection/FpBankConnectionsTest.java index f58f932..606b33d 100644 --- a/src/test/java/org/proshin/finapi/bankconnection/FpBankConnectionsTest.java +++ b/src/test/java/org/proshin/finapi/bankconnection/FpBankConnectionsTest.java @@ -31,7 +31,7 @@ import org.proshin.finapi.bankconnection.in.UpdateBankConnectionParameters; import org.proshin.finapi.fake.FakeAccessToken; -public class FpBankConnectionsTest extends TestWithMockedEndpoint { +public final class FpBankConnectionsTest extends TestWithMockedEndpoint { @Test public void testOne() { diff --git a/src/test/java/org/proshin/finapi/bankconnection/out/FpBankConsentTest.java b/src/test/java/org/proshin/finapi/bankconnection/out/FpBankConsentTest.java index bf0b814..68adff6 100644 --- a/src/test/java/org/proshin/finapi/bankconnection/out/FpBankConsentTest.java +++ b/src/test/java/org/proshin/finapi/bankconnection/out/FpBankConsentTest.java @@ -21,7 +21,7 @@ import static org.proshin.finapi.bankconnection.out.BankConsent.Status.PRESENT; import org.proshin.finapi.primitives.OffsetDateTimeOf; -public class FpBankConsentTest { +public final class FpBankConsentTest { @Test public void test() { diff --git a/src/test/java/org/proshin/finapi/bankconnection/out/FpOwnerTest.java b/src/test/java/org/proshin/finapi/bankconnection/out/FpOwnerTest.java index 7956458..81b3071 100644 --- a/src/test/java/org/proshin/finapi/bankconnection/out/FpOwnerTest.java +++ b/src/test/java/org/proshin/finapi/bankconnection/out/FpOwnerTest.java @@ -21,7 +21,7 @@ import org.json.JSONObject; import org.junit.jupiter.api.Test; -public class FpOwnerTest { +public final class FpOwnerTest { @Test public void test() { final Owner owner = new FpOwner( diff --git a/src/test/java/org/proshin/finapi/bankconnection/out/FpTwoStepProceduresTest.java b/src/test/java/org/proshin/finapi/bankconnection/out/FpTwoStepProceduresTest.java index a89425e..731d494 100644 --- a/src/test/java/org/proshin/finapi/bankconnection/out/FpTwoStepProceduresTest.java +++ b/src/test/java/org/proshin/finapi/bankconnection/out/FpTwoStepProceduresTest.java @@ -19,7 +19,7 @@ import org.json.JSONObject; import org.junit.jupiter.api.Test; -public class FpTwoStepProceduresTest { +public final class FpTwoStepProceduresTest { @Test public void testThatExceptionIsThrownIfDefaultDoesNotMatchAnyProcedure() { diff --git a/src/test/java/org/proshin/finapi/category/FpCategoriesTest.java b/src/test/java/org/proshin/finapi/category/FpCategoriesTest.java index a6bf434..f01610d 100644 --- a/src/test/java/org/proshin/finapi/category/FpCategoriesTest.java +++ b/src/test/java/org/proshin/finapi/category/FpCategoriesTest.java @@ -29,13 +29,14 @@ import org.proshin.finapi.category.in.CategoriesCriteria; import org.proshin.finapi.category.in.CreateCategoryParameters; import org.proshin.finapi.category.in.TrainCategorizationParameters; +import org.proshin.finapi.category.in.TrainCategorizationTransaction; import org.proshin.finapi.category.out.CashFlows; import org.proshin.finapi.fake.FakeAccessToken; import org.proshin.finapi.primitives.Direction; import org.proshin.finapi.primitives.LocalDateOf; import org.proshin.finapi.primitives.paging.Page; -public class FpCategoriesTest extends TestWithMockedEndpoint { +public final class FpCategoriesTest extends TestWithMockedEndpoint { @Test public void testOne() { @@ -207,7 +208,7 @@ public void testTrainCategorization() { ).trainCategorization( new TrainCategorizationParameters() .withTransactions( - new TrainCategorizationParameters.TrainCategorizationTransaction() + new TrainCategorizationTransaction() .withAccountType(Type.Checking) .withAmount(new BigDecimal("-99.99")) .withPurpose("Restaurantbesuch") diff --git a/src/test/java/org/proshin/finapi/category/FpCategoryTest.java b/src/test/java/org/proshin/finapi/category/FpCategoryTest.java index a9b1711..ce3de82 100644 --- a/src/test/java/org/proshin/finapi/category/FpCategoryTest.java +++ b/src/test/java/org/proshin/finapi/category/FpCategoryTest.java @@ -27,7 +27,7 @@ import org.proshin.finapi.category.in.FpEditParameters; import org.proshin.finapi.fake.FakeAccessToken; -public class FpCategoryTest extends TestWithMockedEndpoint { +public final class FpCategoryTest extends TestWithMockedEndpoint { @Test public void test() { diff --git a/src/test/java/org/proshin/finapi/category/out/FpCashFlowTest.java b/src/test/java/org/proshin/finapi/category/out/FpCashFlowTest.java index 5c3b1e7..8a0e8b4 100644 --- a/src/test/java/org/proshin/finapi/category/out/FpCashFlowTest.java +++ b/src/test/java/org/proshin/finapi/category/out/FpCashFlowTest.java @@ -22,7 +22,8 @@ import org.proshin.finapi.TestWithMockedEndpoint; import org.proshin.finapi.fake.FakeAccessToken; -public class FpCashFlowTest extends TestWithMockedEndpoint { +public final class FpCashFlowTest extends TestWithMockedEndpoint { + @Test public void test() { final CashFlow cashFlow = new FpCashFlow( diff --git a/src/test/java/org/proshin/finapi/client/FpClientTest.java b/src/test/java/org/proshin/finapi/client/FpClientTest.java index 5515711..1a7def0 100644 --- a/src/test/java/org/proshin/finapi/client/FpClientTest.java +++ b/src/test/java/org/proshin/finapi/client/FpClientTest.java @@ -30,7 +30,7 @@ import org.proshin.finapi.user.Users; import org.proshin.finapi.user.in.FpCreateParameters; -public class FpClientTest extends TestWithMockedEndpoint { +public final class FpClientTest extends TestWithMockedEndpoint { @Test public void testConfiguration() { diff --git a/src/test/java/org/proshin/finapi/exception/FinapiExceptionTest.java b/src/test/java/org/proshin/finapi/exception/FinapiExceptionTest.java index 746be61..9370bd5 100644 --- a/src/test/java/org/proshin/finapi/exception/FinapiExceptionTest.java +++ b/src/test/java/org/proshin/finapi/exception/FinapiExceptionTest.java @@ -22,7 +22,7 @@ import org.proshin.finapi.bankconnection.out.TwoStepProcedure; import org.proshin.finapi.primitives.OffsetDateTimeOf; -public class FinapiExceptionTest { +public final class FinapiExceptionTest { @Test public void test() { diff --git a/src/test/java/org/proshin/finapi/fake/FakeRoute.java b/src/test/java/org/proshin/finapi/fake/FakeRoute.java index 562c3f6..a443d87 100644 --- a/src/test/java/org/proshin/finapi/fake/FakeRoute.java +++ b/src/test/java/org/proshin/finapi/fake/FakeRoute.java @@ -44,15 +44,15 @@ public FakeRoute(final PathMatcher pathMatcher, final TokenMatcher tokenMatcher, this.response = response; } - boolean matches(final String path) { + public boolean matches(final String path) { return this.pathMatcher.matches(path); } - boolean matches(final AccessToken accessToken, final String path) { + public boolean matches(final AccessToken accessToken, final String path) { return this.tokenMatcher.matches(accessToken.accessToken()) && this.pathMatcher.matches(path); } - String response() { + public String response() { return this.response; } } diff --git a/src/test/java/org/proshin/finapi/label/FpLabelTest.java b/src/test/java/org/proshin/finapi/label/FpLabelTest.java index 3fe6127..a945171 100644 --- a/src/test/java/org/proshin/finapi/label/FpLabelTest.java +++ b/src/test/java/org/proshin/finapi/label/FpLabelTest.java @@ -21,7 +21,8 @@ import org.proshin.finapi.TestWithMockedEndpoint; import org.proshin.finapi.fake.FakeAccessToken; -public class FpLabelTest extends TestWithMockedEndpoint { +public final class FpLabelTest extends TestWithMockedEndpoint { + @Test public void test() { final Label label = new FpLabel( diff --git a/src/test/java/org/proshin/finapi/label/LabelsTest.java b/src/test/java/org/proshin/finapi/label/LabelsTest.java index b080c03..4521f1b 100644 --- a/src/test/java/org/proshin/finapi/label/LabelsTest.java +++ b/src/test/java/org/proshin/finapi/label/LabelsTest.java @@ -24,7 +24,7 @@ import org.proshin.finapi.label.in.LabelsCriteria; import org.proshin.finapi.primitives.paging.Page; -public class LabelsTest extends TestWithMockedEndpoint { +public final class LabelsTest extends TestWithMockedEndpoint { @Test public void testOne() { diff --git a/src/test/java/org/proshin/finapi/mandator/FpMandatorTest.java b/src/test/java/org/proshin/finapi/mandator/FpMandatorTest.java index 4884925..ba4dca3 100644 --- a/src/test/java/org/proshin/finapi/mandator/FpMandatorTest.java +++ b/src/test/java/org/proshin/finapi/mandator/FpMandatorTest.java @@ -25,7 +25,7 @@ import org.proshin.finapi.mandator.in.UsersCriteria; import org.proshin.finapi.primitives.OffsetDateTimeOf; -public class FpMandatorTest extends TestWithMockedEndpoint { +public final class FpMandatorTest extends TestWithMockedEndpoint { @Test public void testUsers() { diff --git a/src/test/java/org/proshin/finapi/mandator/out/FpDeletionResultTest.java b/src/test/java/org/proshin/finapi/mandator/out/FpDeletionResultTest.java index 5b3d824..f65faff 100644 --- a/src/test/java/org/proshin/finapi/mandator/out/FpDeletionResultTest.java +++ b/src/test/java/org/proshin/finapi/mandator/out/FpDeletionResultTest.java @@ -19,7 +19,8 @@ import org.json.JSONObject; import org.junit.jupiter.api.Test; -public class FpDeletionResultTest { +public final class FpDeletionResultTest { + @Test public void test() { final DeletionResult result = new FpDeletionResult( diff --git a/src/test/java/org/proshin/finapi/mandator/out/FpUserTest.java b/src/test/java/org/proshin/finapi/mandator/out/FpUserTest.java index 5874a6d..da1d5b3 100644 --- a/src/test/java/org/proshin/finapi/mandator/out/FpUserTest.java +++ b/src/test/java/org/proshin/finapi/mandator/out/FpUserTest.java @@ -22,7 +22,8 @@ import org.junit.jupiter.api.Test; import org.proshin.finapi.primitives.LocalDateOf; -public class FpUserTest { +public final class FpUserTest { + @Test public void test() { final User user = new FpUser(new JSONObject('{' + diff --git a/src/test/java/org/proshin/finapi/mock/FpMocksAndTestsTest.java b/src/test/java/org/proshin/finapi/mock/FpMocksAndTestsTest.java index 3c7ee9e..ff483c2 100644 --- a/src/test/java/org/proshin/finapi/mock/FpMocksAndTestsTest.java +++ b/src/test/java/org/proshin/finapi/mock/FpMocksAndTestsTest.java @@ -34,7 +34,7 @@ import org.proshin.finapi.primitives.BankingInterface; @SuppressWarnings("JUnitTestMethodWithNoAssertions") -public class FpMocksAndTestsTest extends TestWithMockedEndpoint { +public final class FpMocksAndTestsTest extends TestWithMockedEndpoint { @Test public void testMockBatchUpdate() { diff --git a/src/test/java/org/proshin/finapi/mock/out/FpCategorizationResultTest.java b/src/test/java/org/proshin/finapi/mock/out/FpCategorizationResultTest.java index 4476de1..f59a7fd 100644 --- a/src/test/java/org/proshin/finapi/mock/out/FpCategorizationResultTest.java +++ b/src/test/java/org/proshin/finapi/mock/out/FpCategorizationResultTest.java @@ -21,7 +21,8 @@ import org.proshin.finapi.endpoint.FpEndpoint; import org.proshin.finapi.fake.FakeAccessToken; -public class FpCategorizationResultTest { +public final class FpCategorizationResultTest { + @Test public void test() { final CategorizationResult result = new FpCategorizationResult( diff --git a/src/test/java/org/proshin/finapi/notificationrule/FpNotificationRuleTest.java b/src/test/java/org/proshin/finapi/notificationrule/FpNotificationRuleTest.java index d136e83..cb91022 100644 --- a/src/test/java/org/proshin/finapi/notificationrule/FpNotificationRuleTest.java +++ b/src/test/java/org/proshin/finapi/notificationrule/FpNotificationRuleTest.java @@ -27,7 +27,7 @@ import org.proshin.finapi.TestWithMockedEndpoint; import org.proshin.finapi.fake.FakeAccessToken; -public class FpNotificationRuleTest extends TestWithMockedEndpoint { +public final class FpNotificationRuleTest extends TestWithMockedEndpoint { @Test public void testWithParams() { diff --git a/src/test/java/org/proshin/finapi/notificationrule/FpNotificationRulesTest.java b/src/test/java/org/proshin/finapi/notificationrule/FpNotificationRulesTest.java index 12a8466..a02dc93 100644 --- a/src/test/java/org/proshin/finapi/notificationrule/FpNotificationRulesTest.java +++ b/src/test/java/org/proshin/finapi/notificationrule/FpNotificationRulesTest.java @@ -34,7 +34,7 @@ import org.proshin.finapi.notificationrule.in.params.NewAccountBalanceParams; import org.proshin.finapi.notificationrule.in.params.NewTransactionsParams; -public class FpNotificationRulesTest extends TestWithMockedEndpoint { +public final class FpNotificationRulesTest extends TestWithMockedEndpoint { @Test public void testOne() { diff --git a/src/test/java/org/proshin/finapi/notificationrule/in/CreatingParametersTest.java b/src/test/java/org/proshin/finapi/notificationrule/in/CreatingParametersTest.java index 8c9bc20..5d85383 100644 --- a/src/test/java/org/proshin/finapi/notificationrule/in/CreatingParametersTest.java +++ b/src/test/java/org/proshin/finapi/notificationrule/in/CreatingParametersTest.java @@ -21,7 +21,7 @@ import org.proshin.finapi.notificationrule.TriggerEvent; import org.proshin.finapi.notificationrule.in.params.BankLoginErrorParams; -public class CreatingParametersTest { +public final class CreatingParametersTest { @Test public void testIncompatibleEventAndParams() { diff --git a/src/test/java/org/proshin/finapi/payment/FpPaymentsTest.java b/src/test/java/org/proshin/finapi/payment/FpPaymentsTest.java index 5f133c6..8c21dc8 100644 --- a/src/test/java/org/proshin/finapi/payment/FpPaymentsTest.java +++ b/src/test/java/org/proshin/finapi/payment/FpPaymentsTest.java @@ -25,7 +25,7 @@ import org.proshin.finapi.payment.in.FpQueryCriteria; import org.proshin.finapi.primitives.paging.Page; -public class FpPaymentsTest extends TestWithMockedEndpoint { +public final class FpPaymentsTest extends TestWithMockedEndpoint { @Test public void testQuery() { diff --git a/src/test/java/org/proshin/finapi/primitives/IterableJsonArrayTest.java b/src/test/java/org/proshin/finapi/primitives/IterableJsonArrayTest.java index cf47ce0..9eff083 100644 --- a/src/test/java/org/proshin/finapi/primitives/IterableJsonArrayTest.java +++ b/src/test/java/org/proshin/finapi/primitives/IterableJsonArrayTest.java @@ -22,7 +22,7 @@ import org.json.JSONArray; import org.junit.jupiter.api.Test; -public class IterableJsonArrayTest { +public final class IterableJsonArrayTest { @Test public void testHasNext() { diff --git a/src/test/java/org/proshin/finapi/primitives/StringOfTest.java b/src/test/java/org/proshin/finapi/primitives/StringOfTest.java index 3eb399e..26b34ed 100644 --- a/src/test/java/org/proshin/finapi/primitives/StringOfTest.java +++ b/src/test/java/org/proshin/finapi/primitives/StringOfTest.java @@ -21,7 +21,8 @@ import static org.assertj.core.api.Assertions.assertThat; import org.junit.jupiter.api.Test; -public class StringOfTest { +public final class StringOfTest { + @Test public void testStringOfOffsetDateTime() { assertThat(new StringOf(OffsetDateTime.of(2018, 10, 25, 1, 2, 3, 4, ZoneOffset.UTC)).toString()) diff --git a/src/test/java/org/proshin/finapi/primitives/paging/FpPageTest.java b/src/test/java/org/proshin/finapi/primitives/paging/FpPageTest.java index 52c6986..22e407a 100644 --- a/src/test/java/org/proshin/finapi/primitives/paging/FpPageTest.java +++ b/src/test/java/org/proshin/finapi/primitives/paging/FpPageTest.java @@ -22,7 +22,7 @@ import org.json.JSONObject; import org.junit.jupiter.api.Test; -public class FpPageTest { +public final class FpPageTest { @Test public void testItems() throws Exception { diff --git a/src/test/java/org/proshin/finapi/primitives/paging/FpPagingTest.java b/src/test/java/org/proshin/finapi/primitives/paging/FpPagingTest.java index 6e528b4..c1b9c63 100644 --- a/src/test/java/org/proshin/finapi/primitives/paging/FpPagingTest.java +++ b/src/test/java/org/proshin/finapi/primitives/paging/FpPagingTest.java @@ -19,7 +19,8 @@ import org.json.JSONObject; import org.junit.jupiter.api.Test; -public class FpPagingTest { +public final class FpPagingTest { + @Test public void test() { final Paging paging = new FpPaging( diff --git a/src/test/java/org/proshin/finapi/security/FpSecuritiesTest.java b/src/test/java/org/proshin/finapi/security/FpSecuritiesTest.java index 3303801..b08e342 100644 --- a/src/test/java/org/proshin/finapi/security/FpSecuritiesTest.java +++ b/src/test/java/org/proshin/finapi/security/FpSecuritiesTest.java @@ -23,7 +23,7 @@ import org.proshin.finapi.fake.FakeAccessToken; import org.proshin.finapi.security.in.SecuritiesCriteria; -public class FpSecuritiesTest extends TestWithMockedEndpoint { +public final class FpSecuritiesTest extends TestWithMockedEndpoint { @Test public void testOne() { diff --git a/src/test/java/org/proshin/finapi/security/FpSecurityTest.java b/src/test/java/org/proshin/finapi/security/FpSecurityTest.java index fe025b6..71ab06c 100644 --- a/src/test/java/org/proshin/finapi/security/FpSecurityTest.java +++ b/src/test/java/org/proshin/finapi/security/FpSecurityTest.java @@ -24,7 +24,7 @@ import org.proshin.finapi.security.out.QuantityNominalType; import org.proshin.finapi.security.out.QuoteType; -public class FpSecurityTest { +public final class FpSecurityTest { @Test public void test() { diff --git a/src/test/java/org/proshin/finapi/tppcertificate/FpTppCertificateTest.java b/src/test/java/org/proshin/finapi/tppcertificate/FpTppCertificateTest.java index 6fec322..310ded2 100644 --- a/src/test/java/org/proshin/finapi/tppcertificate/FpTppCertificateTest.java +++ b/src/test/java/org/proshin/finapi/tppcertificate/FpTppCertificateTest.java @@ -26,7 +26,7 @@ import org.proshin.finapi.fake.FakeAccessToken; import org.proshin.finapi.primitives.LocalDateOf; -public class FpTppCertificateTest extends TestWithMockedEndpoint { +public final class FpTppCertificateTest extends TestWithMockedEndpoint { @Test public void test() { diff --git a/src/test/java/org/proshin/finapi/tppcertificate/FpTppCertificatesTest.java b/src/test/java/org/proshin/finapi/tppcertificate/FpTppCertificatesTest.java index 5d21eef..a26472b 100644 --- a/src/test/java/org/proshin/finapi/tppcertificate/FpTppCertificatesTest.java +++ b/src/test/java/org/proshin/finapi/tppcertificate/FpTppCertificatesTest.java @@ -25,7 +25,7 @@ import org.proshin.finapi.primitives.paging.Page; import org.proshin.finapi.tppcertificate.in.QueryTppCertificatesCriteria; -public class FpTppCertificatesTest extends TestWithMockedEndpoint { +public final class FpTppCertificatesTest extends TestWithMockedEndpoint { @Test public void testOne() { diff --git a/src/test/java/org/proshin/finapi/tppcertificate/in/CreateTppCertificateParametersTest.java b/src/test/java/org/proshin/finapi/tppcertificate/in/CreateTppCertificateParametersTest.java index abd0241..f121250 100644 --- a/src/test/java/org/proshin/finapi/tppcertificate/in/CreateTppCertificateParametersTest.java +++ b/src/test/java/org/proshin/finapi/tppcertificate/in/CreateTppCertificateParametersTest.java @@ -20,7 +20,7 @@ import org.proshin.finapi.primitives.LocalDateOf; import org.proshin.finapi.tppcertificate.CertificateType; -public class CreateTppCertificateParametersTest { +public final class CreateTppCertificateParametersTest { @Test public void test() { diff --git a/src/test/java/org/proshin/finapi/tppcredential/FpTppAuthenticationGroupTest.java b/src/test/java/org/proshin/finapi/tppcredential/FpTppAuthenticationGroupTest.java index 0473d8e..050eaf8 100644 --- a/src/test/java/org/proshin/finapi/tppcredential/FpTppAuthenticationGroupTest.java +++ b/src/test/java/org/proshin/finapi/tppcredential/FpTppAuthenticationGroupTest.java @@ -25,7 +25,7 @@ import org.proshin.finapi.primitives.paging.Page; import org.proshin.finapi.tppcredential.in.QueryTppAuthenticationGroupsCriteria; -public class FpTppAuthenticationGroupTest extends TestWithMockedEndpoint { +public final class FpTppAuthenticationGroupTest extends TestWithMockedEndpoint { @Test public void testQuery() { diff --git a/src/test/java/org/proshin/finapi/tppcredential/FpTppCredentialTest.java b/src/test/java/org/proshin/finapi/tppcredential/FpTppCredentialTest.java index b39e9c8..984fef1 100644 --- a/src/test/java/org/proshin/finapi/tppcredential/FpTppCredentialTest.java +++ b/src/test/java/org/proshin/finapi/tppcredential/FpTppCredentialTest.java @@ -26,7 +26,7 @@ import org.proshin.finapi.fake.FakeAccessToken; import org.proshin.finapi.primitives.LocalDateOf; -public class FpTppCredentialTest extends TestWithMockedEndpoint { +public final class FpTppCredentialTest extends TestWithMockedEndpoint { @Test public void test() { diff --git a/src/test/java/org/proshin/finapi/tppcredential/FpTppCredentialsTest.java b/src/test/java/org/proshin/finapi/tppcredential/FpTppCredentialsTest.java index 2d04ce4..a1a1eca 100644 --- a/src/test/java/org/proshin/finapi/tppcredential/FpTppCredentialsTest.java +++ b/src/test/java/org/proshin/finapi/tppcredential/FpTppCredentialsTest.java @@ -28,7 +28,7 @@ import org.proshin.finapi.tppcredential.in.EditTppCredentialParameters; import org.proshin.finapi.tppcredential.in.QueryTppCredentialsCriteria; -public class FpTppCredentialsTest extends TestWithMockedEndpoint { +public final class FpTppCredentialsTest extends TestWithMockedEndpoint { @Test public void testOne() { diff --git a/src/test/java/org/proshin/finapi/tppcredential/in/CreateTppCredentialParametersTest.java b/src/test/java/org/proshin/finapi/tppcredential/in/CreateTppCredentialParametersTest.java index a0f0132..7114e0a 100644 --- a/src/test/java/org/proshin/finapi/tppcredential/in/CreateTppCredentialParametersTest.java +++ b/src/test/java/org/proshin/finapi/tppcredential/in/CreateTppCredentialParametersTest.java @@ -19,7 +19,7 @@ import org.junit.jupiter.api.Test; import org.proshin.finapi.primitives.LocalDateOf; -public class CreateTppCredentialParametersTest { +public final class CreateTppCredentialParametersTest { @Test public void test() { diff --git a/src/test/java/org/proshin/finapi/transaction/FpTransactionTest.java b/src/test/java/org/proshin/finapi/transaction/FpTransactionTest.java index b675bf9..1fab1e7 100644 --- a/src/test/java/org/proshin/finapi/transaction/FpTransactionTest.java +++ b/src/test/java/org/proshin/finapi/transaction/FpTransactionTest.java @@ -32,7 +32,7 @@ import org.proshin.finapi.transaction.in.SplitTransactionParameters; import org.proshin.finapi.transaction.in.Subtransaction; -public class FpTransactionTest extends TestWithMockedEndpoint { +public final class FpTransactionTest extends TestWithMockedEndpoint { @Test public void test() { diff --git a/src/test/java/org/proshin/finapi/transaction/FpTransactionsTest.java b/src/test/java/org/proshin/finapi/transaction/FpTransactionsTest.java index 6d90f4d..76c5546 100644 --- a/src/test/java/org/proshin/finapi/transaction/FpTransactionsTest.java +++ b/src/test/java/org/proshin/finapi/transaction/FpTransactionsTest.java @@ -32,7 +32,7 @@ import org.proshin.finapi.transaction.in.TransactionsCriteria; import org.proshin.finapi.transaction.out.TransactionsPage; -public class FpTransactionsTest extends TestWithMockedEndpoint { +public final class FpTransactionsTest extends TestWithMockedEndpoint { @Test public void testOne() { diff --git a/src/test/java/org/proshin/finapi/webform/FpWebFormTest.java b/src/test/java/org/proshin/finapi/webform/FpWebFormTest.java index d1dc2dc..6520684 100644 --- a/src/test/java/org/proshin/finapi/webform/FpWebFormTest.java +++ b/src/test/java/org/proshin/finapi/webform/FpWebFormTest.java @@ -20,7 +20,7 @@ import org.json.JSONObject; import org.junit.jupiter.api.Test; -public class FpWebFormTest { +public final class FpWebFormTest { @Test public void testSuccess() { diff --git a/src/test/java/org/proshin/finapi/webform/WebFormsTest.java b/src/test/java/org/proshin/finapi/webform/WebFormsTest.java index 09f6366..1bcec88 100644 --- a/src/test/java/org/proshin/finapi/webform/WebFormsTest.java +++ b/src/test/java/org/proshin/finapi/webform/WebFormsTest.java @@ -21,7 +21,7 @@ import org.proshin.finapi.TestWithMockedEndpoint; import org.proshin.finapi.fake.FakeAccessToken; -public class WebFormsTest extends TestWithMockedEndpoint { +public final class WebFormsTest extends TestWithMockedEndpoint { @Test public void testOne() {