Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hugging Face as selectable model path #58

Closed
seanpmorgan opened this issue Nov 21, 2023 · 0 comments · Fixed by #60
Closed

Remove Hugging Face as selectable model path #58

seanpmorgan opened this issue Nov 21, 2023 · 0 comments · Fixed by #60
Labels
bug Something isn't working

Comments

@seanpmorgan
Copy link
Member

Currently, we have bespoke support for passing a Hugging Face model name to ModelScan. While a nice feature, this expands the scope of ModelScan to larger than it needs to be:

  1. Why Hugging Face and not other popular OSS model repositories?
  2. We don't properly handle edge cases in HF and don't want to sign up to do so (e.g. HF tokens and models that require you to accept ToS)
  3. It makes it so an http client library is a core dependency of ModelScan

Since we're still at a 0.x release, we should remove this capability before it is depended on and not properly maintained. Users can easily download models using their own methods (e.g. hugginface_hub, requests, etc. ) and then use ModelScan once it's available on local disk.

@seanpmorgan seanpmorgan added the bug Something isn't working label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant