-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to reset HistoryManager #463
Comments
@bdionne Please can you explain why this happens? Is it because of the way the project is loaded? |
When the project loads, the change history is fetched from the server in the form of list of This is somewhat mitigated in the client we're using as we load first from a snapshot, so the history applied from the server will be smaller. |
I see, thanks. I guess these changes should be silently applied as they aren't the result of user actions. This way, the history manager, or any other object that listens for changes won't apply them. Would there be any side effects to this solution from your point of view? |
That works, if by silently you mean in this kind of case we'd call a different method such as I do still want to be able to get at History and use the Undo functionality, which I can do as there's a |
Yes, something like this. |
As I consider it more, there's also the case of committing changes to the server, after which it would be nice to reset the history manager, or not, I can see use cases where you'd want both capabilities |
The
HistoryManager
that supports theundo/redo
functionality in the editor does not play well with the protege client. When an existing project is opened the entire change history is loaded into the manager. We need the ability to reset the history, as this is not the intended semantics in this case, rather the idea is to capture edits in the current session. Something like this workaround seems simple enough, though an interface method would be preferrableThe text was updated successfully, but these errors were encountered: