Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive expansion of hierarchies (ALT+Click) does not work properly #468

Closed
ykazakov opened this issue Jul 4, 2016 · 5 comments
Closed

Comments

@ykazakov
Copy link
Contributor

ykazakov commented Jul 4, 2016

If I click on owl:Thing in the class hierarchy view (asserted or inferred) while holding the ALT/Option key, the hierarchy does not expand recursively, just one level (as without ALT).
If, however, while holding ALT I first close the hierarchy and then open it, it expands correctly.
I have looked in the debugger, and it seems that the culprit is that in OWLObjectTree the mouse listener which sets altDown is fired after the TreeExpansionListener that checks the value of altDown.

Tested on mac OS X 10.11.5 with the latest Protege 5 (built from sources):

@matthewhorridge
Copy link
Contributor

I can't reproduce this using the Mac OS L&F, but using the Protege LAF I can.

@ykazakov
Copy link
Contributor Author

ykazakov commented Jul 6, 2016

Indeed, I had a different L&F. With Mac OS X L&F seems to work fine. Still, I think it would be better not to rely on the order in which the listeners are called.

@matthewhorridge
Copy link
Contributor

Yep, I'm rewriting the code....

@ykazakov
Copy link
Contributor Author

ykazakov commented Aug 4, 2016

I just tested Alt+Click for the latest version built from master, and while the recursive expansion now works, something is wrong with the label -- it is rotated 180 degrees, not 90. See the screenshot:

screen shot 2016-08-04 at 14 05 01

@matthewhorridge
Copy link
Contributor

This was the visual artefact that I observed with the fix. On OS X there's an animation of the triangle and it gets stuck on the second frame with this fix. I'm not sure why this occurs because I haven't looked into it any further. However, I thought it was still worth having the fix over not having it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants