Add a modular graphql server #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpanic
force-pushed
the
feature/graphql
branch
from
b4f4142 to
b6ce433
Compare
rpanic
force-pushed
the
feature/graphql
branch
from
bb8cfb0 to
f389034
Compare
maht0rz
reviewed
Nov 2, 2023
maht0rz
requested changes
Nov 2, 2023
| export function graphqlModule() { | ||
| return ( | ||
| /** | ||
| * Check if the target class extends RuntimeModule, while |
| import { GraphqlServer } from "./GraphqlServer"; | ||
| import { SchemaGeneratingGraphqlModule } from "./GraphqlModule"; | ||
|
|
||
| export type GraphqlModulesRecord = ModulesRecord<any>; |
There was a problem hiding this comment.
Shouldn't this be ModulesRecord<TypedClass<GraphqlModule<unknown>>>?
| public async start(): Promise<void> { | ||
| assert(this.graphqlServer !== undefined); | ||
|
|
||
| this.graphqlServer.setContext(this.container); |
|
|
||
| const yoga = createYoga<Koa.ParameterizedContext>({ | ||
| schema, | ||
| graphiql: true, |
There was a problem hiding this comment.
things like this should be configurable from above
| @@ -10,7 +10,8 @@ | |||
| "lint": "eslint ./src ./test", | |||
| "test:file": "node --experimental-vm-modules --experimental-wasm-modules --experimental-wasm-threads ../../node_modules/jest/bin/jest.js", | |||
| "test": "npm run test:file -- ./src/** ./test/**", | |||
| "test:watch": "npm run test:file -- ./src/** ./test/** --watch" | |||
| "test:watch": "npm run test:file -- ./src/** ./test/** --watch", | |||
| "graphql": "cd ../api && npm run build && cd ../sdk && npm run build && node --experimental-vm-modules --experimental-wasm-modules --experimental-wasm-threads --es-module-specifier-resolution=node ./dist/graphql.js" | |||
There was a problem hiding this comment.
isn't there a way to run this without building? like a watch/dev mode
packages/sdk/src/graphql.ts
Outdated
There was a problem hiding this comment.
this looks like a testing leftover, should we move it to ./test or something?
| private readonly mempool: Mempool; | ||
|
|
||
| public constructor(@inject("mempool") mempool: Mempool) { | ||
| public constructor(@inject("Mempool") mempool: Mempool) { |
packages/sequencer/package.json
Outdated
| @@ -31,18 +31,11 @@ | |||
| "@types/node": "^20.2.5" | |||
| }, | |||
| "dependencies": { | |||
| "@types/ws": "^8.5.4", | |||
| "@types/koa": "^2.13.10", | |||
There was a problem hiding this comment.
shouldn't this be only a part of the api(-graphql) module?
packages/sdk/src/index.ts
Outdated
| export * from "./transaction/AppChainTransaction"; | ||
| export * from "./transaction/InMemorySigner"; | ||
| export * from "./transaction/InMemoryTransactionSender"; | ||
| export * from "./transaction/AuroSigner"; | ||
| export * from "./graphql"; |
There was a problem hiding this comment.
this should be removed, assuming that file was just for testing purposes
There was a problem hiding this comment.
the reason this is there is bcs prior to using koa, fastify didnt start in a Jest environment, so I had to do this to test stuff
maht0rz
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.