respond to comments

protobufjs · Oct 16, 2024 · 23c8ab9 · 23c8ab9
1 parent 530d59a
commit 23c8ab9
Showing 1 changed file with 2 additions and 17 deletions.
diff --git a/tests/feature_resolution_editions.js b/tests/feature_resolution_editions.js
@@ -237,11 +237,11 @@ tape.test("feature resolution inheritance oneofs", function(test) {
     var rootEditionsOverriden = protobuf.parse(`
     edition = "2023";
     option features.(abc).d_e = deeply_nested_false;
-    message Message {∂
+    message Message {
         oneof SomeOneOf {
             option features.json_format = LEGACY_BEST_EFFORT;
             int32 a = 13;
-            string b = 14;
+            string b = 14 [features.json_format = ALLOW];
         }
     }`).root.resolveAll();
 
@@ -255,21 +255,6 @@ tape.test("feature resolution inheritance oneofs", function(test) {
         '(abc)': { d_e: 'deeply_nested_false' } 
     })
 
-    test.end();
-});
-
-tape.test("feature resolution inheritance oneofs to field", function(test) {
-    var rootEditionsOverriden = protobuf.parse(`
-    edition = "2023";
-    option features.(abc).d_e = deeply_nested_false;
-    message Message {
-        oneof SomeOneOf {
-            option features.json_format = LEGACY_BEST_EFFORT;
-            int32 a = 13;
-            string b = 14 [features.json_format = ALLOW];
-        }
-    }`).root.resolveAll();
-
     test.same(rootEditionsOverriden.lookup("SomeOneOf").fieldsArray.find(x => x.name === 'b')._features, {
         enum_type: 'OPEN',
         field_presence: 'EXPLICIT',