Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance of protobufjs #1199

Closed
hsaliak opened this issue Apr 12, 2019 · 16 comments
Closed

Maintenance of protobufjs #1199

hsaliak opened this issue Apr 12, 2019 · 16 comments

Comments

@hsaliak
Copy link

hsaliak commented Apr 12, 2019

@dcodeIO is the project maintained? As you know, we ( grpc-node team) have protobufJS as a dependency.
If you need some extra hands maintaining the repo and reviewing, we would be happy to help.

@cjihrig
Copy link

cjihrig commented Apr 12, 2019

As a grpc-node user, and Node core team member, I'd just like to add that Node has a package-maintenance team that is looking to help maintain modules from the ecosystem that are heavily relied on. I think protobufjs falls into that category, and I'd be happy to connect you with that group if that's desirable.

@dcodeIO
Copy link
Member

dcodeIO commented Apr 12, 2019

For a bit of background: A while ago I started a new project named AssemblyScript, a TypeScript to WebAsembly compiler, which turned out to be financially supported by interested parties. So my focus since shifted. Not because I wouldn't love protobuf.js, but because I also need to survive somehow to be still around to maintain anything in the first place. I still expect to gravitate back to protobuf.js every once in a while when larger stuff is due, but on my own terms, because I have to.

So, yes, I am open to add additional maintainers from a trusted team relying on protobuf.js. GRPC seems like the best fit.

@dcodeIO dcodeIO pinned this issue Apr 12, 2019
@dcodeIO
Copy link
Member

dcodeIO commented Apr 12, 2019

As a first step I've moved the repository and its (deprecated) hard dependencies to a new organization protobufjs and invited @hsaliak.

@hsaliak
Copy link
Author

hsaliak commented Apr 12, 2019

Unfortunately I am one of the more managerial types.. could you please invite @nicolasnoble and @murgatroid99

@nicolasnoble
Copy link
Member

@hsaliak: you technically can do it yourself now :-)

@dcodeIO
Copy link
Member

dcodeIO commented Apr 13, 2019

Alright, done. You guys should have write access to the repositories now so you can merge PRs, make commits etc. Please let me know if you need anything else or have further questions :).

Can also imagine that setting up automated npm releases based on Git tags would simplify the release process in the long run. Wdyt?

@nicolasnoble
Copy link
Member

That'd be fine with me, yes.

@nicolasnoble
Copy link
Member

So @dcodeIO, there's quite a few more people here at the Google office who can help, and not just myself or @murgatroid99. We in fact have a slew of hands who can help. Would you mind bumping my rights so I can also start building the team, add more people, assign roles, etc?

@dcodeIO
Copy link
Member

dcodeIO commented Apr 18, 2019

Sure, created a team for you guys and added you as its maintainer. Let me know if this works for you :)

@nicolasnoble
Copy link
Member

Unfortunately, it doesn't seem to be quite enough for me to fully add people: image

@dcodeIO
Copy link
Member

dcodeIO commented Apr 18, 2019

I see, seems this doesn't work with teams alone then. You should have full access to the org now :)

@JustinBeckwith JustinBeckwith unpinned this issue Apr 19, 2019
@JustinBeckwith
Copy link
Contributor

Thank you so much @dcodeIO and @nicolasnoble for getting this worked out :) It looks like we have some additional hands to help in here, so I'm going to close this one out!

@eyalpost
Copy link
Contributor

Has the project gone on hiatus again? It doesn't seem like there was any activity from the maintainers in quite some time

@glasser
Copy link

glasser commented Nov 15, 2019

Is this project open to new maintainers? We rely on protobufjs and have some improvements we'd like to make (including one PR that hasn't gotten any response in a few months). We are working on forking protobufjs for our own use, but would be happy to help maintain the actual project as well.

@darioAnongba
Copy link

@glasser Did you manage to fork the project or get some news about maintenance?

@glasser
Copy link

glasser commented Jan 28, 2020

We have a fork for our own use at https://www.npmjs.com/package/@apollo/protobufjs
We don't necessarily want to maintain that as a general-use package though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants