Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobufjs CLI compilation is broken with bad version of marked npm package #1623

Open
utsavkapoor opened this issue Jun 16, 2021 · 3 comments

Comments

@utsavkapoor
Copy link

protobuf.js version: 6.8.3

Protobufjs CLI compilation is broken due a version bump in marked.js which is now incompatible with node version <=14. marked.js has started using optional chaining in their code thus breaking protobuf CLI compilation

npx pbjs -p <proto files> -t static-module -w default --force-message > index.js
protobufjs/cli/node_modules/marked/src/marked.js:158
const prevRenderer = extensions.renderers?.[ext.name];
                                                                           ^
  SyntaxError: Unexpected token '.'
@hanMaster
Copy link

hanMaster commented Jun 16, 2021

version 6.8.8 same issue
can be successfully compiled only with nodejs 10.16

@MickaToast
Copy link

MickaToast commented Jun 16, 2021

Same with latest version 6.11.2 on node v12.18.3.
Error does not occur on node v14.8.0

@davidcorcoran
Copy link

@4eb0da has a workaround here: markedjs/marked#2106 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants