fix(types): nested object can be a oneof #1812
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the type declaration to allow one very special case: a field extension that is a proto3
optional
field. Internally, proto3optional
fields are represented as a single fieldoneof
s, which makes it the first case ever when aoneof
can be anested
object.Example: bigquery-storage
Related part of the JSON:
Yeah, also, last but not least, VSCode does not hang anymore, so removing that comment. It was added 6 years ago, not true anymore.