-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript error in index.d.ts with Long type #753
Comments
See: https://github.com/dcodeIO/protobuf.js#usage-with-typescript I moved it to dev because frontend people (not using long.js) were complaining. Now it's all opt-in. |
there is no problem to compile module directly from VS Code. But what if i use npm for it. It doesn't download modules automatically @types/long is lib only for TS. I think if you publish your module with d.ts in it it has to install other TS dependencies too |
Related: #711 No matter how I do it... |
So you can move it to |
It's a similar situation, though. Without This is a mess. Having strict types in JS where everything is optional is a mess. Not for the user, but for developers of libraries like this one - i.e. where using long.js is optional and running on node is just one side of the coin. Damn it, TypeScript. |
Ok then, this is the intended setup now, born from a bold decision on the management level, and it's doing exactly what you want, surprisingly. I'll send everyone arguing about it in the future right into your direction. It's all your fault now. I wash my hands of it. (jk) |
protobuf.js version: 6.7.1
I'm using you library in my project, but I've got error after last
protobufjs
updateLog
the problem is that you have
@types/long
indevDependencies
, but it must be independencies
The text was updated successfully, but these errors were encountered: