Replace ColdChunkSkipper with iterator-based approach.

PiperOrigin-RevId: 537185836
protocolbuffers · Jun 2, 2023 · ad677f3 · ad677f3
1 parent 46ea61a
commit ad677f3
Show file tree

Hide file tree

Showing 3 changed files with 295 additions and 288 deletions.
diff --git a/src/google/protobuf/compiler/cpp/helpers.cc b/src/google/protobuf/compiler/cpp/helpers.cc
@@ -203,6 +203,10 @@ std::string IntTypeName(const Options& options, absl::string_view type) {
 
 }  // namespace
 
+bool IsRarelyPresent(const FieldDescriptor* field, const Options& options) {
+  return false;
+}
+
 bool IsLazy(const FieldDescriptor* field, const Options& options,
             MessageSCCAnalyzer* scc_analyzer) {
   return IsLazilyVerifiedLazy(field, options) ||

diff --git a/src/google/protobuf/compiler/cpp/helpers.h b/src/google/protobuf/compiler/cpp/helpers.h
@@ -1058,6 +1058,9 @@ std::vector<io::Printer::Sub> AnnotatedAccessors(
 // dynamic initialization.
 bool IsFileDescriptorProto(const FileDescriptor* file, const Options& options);
 
+// Returns true if `field` is unlikely to be present based on PDProto profile.
+bool IsRarelyPresent(const FieldDescriptor* field, const Options& options);
+
 }  // namespace cpp
 }  // namespace compiler
 }  // namespace protobuf