Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGSEV when deep copying a non-reified sub-message in v25 of protobuf #17675

Closed
villainb-dg opened this issue Jul 31, 2024 · 1 comment
Closed
Labels

Comments

@villainb-dg
Copy link

What version of protobuf and what language are you using?
Version: 4.25.4

Language: Python

What operating system (Linux, Windows, ...) and version?

Linux

What runtime / compiler are you using (e.g., python version or gcc version)

Python 3.10.12, grpcio-tools 1.62.2

What did you do?

mkdir test-protobuf
cd test-protobuf
virtualenv .
. bin/activate
pip install protobuf==4.25.4
pip install grpcio-tools=1.62.2
echo 'syntax = "proto3";

message Outer {
        message Inner {
        }
        optional Inner i = 1;
}' >test.proto
python3 -m grpc_tools.protoc -I. --python_out=. test.proto
python3 <<EOF
from test_pb2 import Outer
o = Outer()
o.i.__deepcopy__()
[1]    1710614 segmentation fault (core dumped)  python3 <<<'from test_pb2 import Outer o = Outer() o.i.__deepcopy__()'

What did you expect to see

Not a segmentation fault

What did you see instead?

A segmentation fault

Anything else we should know about your project / environment

The problem was solved in v 5.26* onward because of this commit b9e4894. It was not backported in v25 though so version 4.25.3 onward are affected.

@villainb-dg villainb-dg added the untriaged auto added to all issues by default when created. label Jul 31, 2024
@zhangskz
Copy link
Member

zhangskz commented Aug 2, 2024

Thanks for the report! v25.x is still in support so we can certainly backport this to v25.x for the next v25.4 release.

@zhangskz zhangskz added python and removed untriaged auto added to all issues by default when created. labels Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants