feat: workaround for DOMAIN macro
#12903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a macro on some (older) versions of GCC, and macOS, and Windows. Sigh. I moved the `#undef` block to a common section. I also took the opportunity to add a regression test for all these macros that need to be `#undef`'d.
fowles
approved these changes
May 25, 2023
github-actions
bot
removed
the
🅰️ safe for tests
copybara-service bot
pushed a commit
that referenced
this pull request
May 26, 2023
This is a macro on some (older) versions of GCC, and macOS, and Windows. Sigh. I moved the `#undef` block to a common section. I also took the opportunity to add a regression test for all these macros that need to be `#undef`'d. Part of the work for googleapis/google-cloud-cpp#8125 Closes #12903 FUTURE_COPYBARA_INTEGRATE_REVIEW=#12903 from coryan:feat-workaround-for-domain-macro 2ff5979 PiperOrigin-RevId: 535613595
copybara-service bot
pushed a commit
that referenced
this pull request
May 26, 2023
This is a macro on some (older) versions of GCC, and macOS, and Windows. Sigh. I moved the `#undef` block to a common section. I also took the opportunity to add a regression test for all these macros that need to be `#undef`'d. Part of the work for googleapis/google-cloud-cpp#8125 Closes #12903 FUTURE_COPYBARA_INTEGRATE_REVIEW=#12903 from coryan:feat-workaround-for-domain-macro 2ff5979 PiperOrigin-RevId: 535613595
protobuf-team-bot
added a commit
that referenced
this pull request
May 26, 2023
h-vetinari
pushed a commit
to h-vetinari/protobuf
that referenced
this pull request
Jun 5, 2023
This is a macro on some (older) versions of GCC, and macOS, and Windows. Sigh. I moved the `#undef` block to a common section. I also took the opportunity to add a regression test for all these macros that need to be `#undef`'d. Part of the work for googleapis/google-cloud-cpp#8125 Closes protocolbuffers#12903 PiperOrigin-RevId: 535649278
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
This is a macro on some (older) versions of GCC, and macOS, and Windows. Sigh. I moved the `#undef` block to a common section. I also took the opportunity to add a regression test for all these macros that need to be `#undef`'d. Part of the work for googleapis/google-cloud-cpp#8125 Closes protocolbuffers#12903 PiperOrigin-RevId: 535649278
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a macro on some (older) versions of GCC, and macOS, and Windows. Sigh. I moved the
#undefblock to a common section. I also took the opportunity to add a regression test for all these macros that need to be#undef'd.Part of the work for googleapis/google-cloud-cpp#8125