Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low sensitivity of explicit-types #492

Closed
0xVolosnikov opened this issue Aug 19, 2023 · 3 comments · Fixed by #493
Closed

Low sensitivity of explicit-types #492

0xVolosnikov opened this issue Aug 19, 2023 · 3 comments · Fixed by #493

Comments

@0xVolosnikov
Copy link
Contributor

The explicit-type rule is not checked when casting a variable.

Example

Option: explicit

function test() external {
  uint256 a = uint(10);
}

Expected: error because of uint(10)

Observed: no errors

@dbale-altoros
Copy link
Collaborator

@vladyan18 that's a good catch
I'll try to fix it in next release

Feel free to submit a PR to correct this
Much appreciated

Thanks for posting!

@0xVolosnikov
Copy link
Contributor Author

Feel free to submit a PR to correct this Much appreciated

Already done :)

#493

@dbale-altoros
Copy link
Collaborator

ohh I seee
GREAT WORK!!
I will review it asap

THANKS A LOT!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants