Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune upgrade handlers for 1.19 #1920

Closed
4 tasks
Taztingo opened this issue Apr 9, 2024 · 0 comments · Fixed by #1921
Closed
4 tasks

Prune upgrade handlers for 1.19 #1920

Taztingo opened this issue Apr 9, 2024 · 0 comments · Fixed by #1921
Assignees

Comments

@Taztingo
Copy link
Contributor

Taztingo commented Apr 9, 2024

Summary

Go through upgrades.go and upgrades_test.go and remove unneeded handlers.

Problem Definition

The introduction of hardcoded navs that are used in the upgrade handlers have caused build times to increase significantly. A fresh build can result in a very long build time that lasts up to 10 minutes. This becomes even more of an issue because of how tightly coupled upgrades.go and app.go are, and a slight modification can cause a huge rebuild. Any changes to app.go will force us to compile all related units resulting in us rebuilding the navs after a slight change.

Proposal

  • Delete unused upgrades and functions
  • Delete unused navs

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@Taztingo Taztingo self-assigned this Apr 9, 2024
@Taztingo Taztingo mentioned this issue Apr 9, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant