Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker feegrants not working #2110

Closed
4 tasks
SpicyLemon opened this issue Jul 26, 2024 · 0 comments · Fixed by #2111
Closed
4 tasks

Marker feegrants not working #2110

SpicyLemon opened this issue Jul 26, 2024 · 0 comments · Fixed by #2111
Assignees
Labels
bug Something isn't working marker Marker Module
Milestone

Comments

@SpicyLemon
Copy link
Contributor

Summary of Bug

Marker funds cannot be used to pay for fees via a feegrant.

Version

v1.19.1

Steps to Reproduce

  1. Create a coin marker with zero supply, and send some nhash to it. This is the same setup we use for our hash grants.
  2. Use the marker module's GrantAllowance endpoint to create a feegrant that another address can use to spend some (or all) of the nhash in that marker.
  3. Attempt to do a transaction with the marker address as the fee-granter.

You'll get an error that looks like this:

cannot withdraw from marker account pb1zueukfejxrvurmrqup9sgqwfwfyra7mygz9f34 (grant0077): account: pb1zueukfejxrvurmrqup9sgqwfwfyra7mygz9f34: insufficient funds

In the marker module's send restriction, when the from address is a marker, we currently require a transfer agent. If there is no transfer agent, that "cannot withdraw from marker account ..." error is returned.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@SpicyLemon SpicyLemon added bug Something isn't working marker Marker Module labels Jul 26, 2024
@SpicyLemon SpicyLemon self-assigned this Jul 26, 2024
@SpicyLemon SpicyLemon moved this from Todo to In Progress in Provenance Core Protocol Team Jul 29, 2024
@SpicyLemon SpicyLemon added this to the v1.20.0 milestone Jul 29, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Provenance Core Protocol Team Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working marker Marker Module
Projects
Development

Successfully merging a pull request may close this issue.

1 participant