From 3357342efece20ac61689d05e631108216fbb7f3 Mon Sep 17 00:00:00 2001 From: Daniel Wedul Date: Tue, 9 Jul 2024 12:22:29 -0600 Subject: [PATCH] Create the (empty) umber-rc2 upgrade. (#2069) * Add the umber-rc2 upgrade (which does nothing). * Add changelog entry. --- CHANGELOG.md | 4 +++- app/upgrades.go | 3 ++- app/upgrades_test.go | 12 ++++++++++++ 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b245d9986..c1e91aa57 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -37,7 +37,9 @@ Ref: https://keepachangelog.com/en/1.0.0/ ## [Unreleased] -* nothing +### Improvements + +* Add the (empty) `umber-rc2` upgrade [#2069](https://github.com/provenance-io/provenance/pull/2069). --- diff --git a/app/upgrades.go b/app/upgrades.go index ce7e207ec..f5ba971ac 100644 --- a/app/upgrades.go +++ b/app/upgrades.go @@ -56,7 +56,7 @@ type appUpgrade struct { // If something is happening in the rc upgrade(s) that isn't being applied in the non-rc, // or vice versa, please add comments explaining why in both entries. var upgrades = map[string]appUpgrade{ - "umber-rc1": { // upgrade for v1.19.0-rc1 + "umber-rc1": { // upgrade for v1.19.0-rc2 Added: []string{crisistypes.ModuleName, circuittypes.ModuleName, consensusparamtypes.ModuleName}, Deleted: []string{"reward"}, Handler: func(ctx sdk.Context, app *App, vm module.VersionMap) (module.VersionMap, error) { @@ -105,6 +105,7 @@ var upgrades = map[string]appUpgrade{ return vm, nil }, }, + "umber-rc2": {}, // upgrade for v1.19.0-rc3 "umber": { // upgrade for v1.19.0 Added: []string{crisistypes.ModuleName, circuittypes.ModuleName, consensusparamtypes.ModuleName}, Deleted: []string{"reward"}, diff --git a/app/upgrades_test.go b/app/upgrades_test.go index 4b0775577..070216ef4 100644 --- a/app/upgrades_test.go +++ b/app/upgrades_test.go @@ -402,6 +402,18 @@ func (s *UpgradeTestSuite) TestUmberRC1() { s.AssertUpgradeHandlerLogs("umber-rc1", expInLog, nil) } +func (s *UpgradeTestSuite) TestUmberRC2() { + key := "umber-rc2" + s.Assert().Contains(upgrades, key, "%q defined upgrades map", key) + + entry := upgrades[key] + s.Assert().NotNil(entry, "%q entry in the upgrades map", key) + s.Assert().Empty(entry.Added, "%q.Added", key) + s.Assert().Empty(entry.Deleted, "%q.Deleted", key) + s.Assert().Empty(entry.Renamed, "%q.Renamed", key) + s.Assert().Nil(entry.Handler, "%q.Handler", key) +} + func (s *UpgradeTestSuite) TestUmber() { expInLog := []string{ "INF Pruning expired consensus states for IBC.",