Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-phaser dist appears to bundle Phaser #18

Closed
JingYenLoh opened this issue Jun 6, 2020 · 8 comments
Closed

ion-phaser dist appears to bundle Phaser #18

JingYenLoh opened this issue Jun 6, 2020 · 8 comments

Comments

@JingYenLoh
Copy link

core/dist/esm-es5/ion-phaser.entry.js appears to bundle Phaser in, although #7 reports a much smaller bundle size.

@jdnichollsc
Copy link
Member

The bundle size doesn't include Phaser: https://bundlephobia.com/result?p=@ion-phaser/core@1.2.3

@JingYenLoh
Copy link
Author

Yes, I've seen that link, but looking at the file it doesn't seem that way.

I've created a minimal repro in React. This is the map it generates.

image

@jdnichollsc
Copy link
Member

You're right, let me investigate 👍 https://unpkg.com/@ion-phaser/core@1.2.3/dist/esm-es5/ion-phaser.entry.js

@jdnichollsc
Copy link
Member

I'm going to try with the last version of StencilJS, please stay tuned :)

@alcaitiff
Copy link

Nothing until now?

@jdnichollsc
Copy link
Member

Let me try using last version of StencilJS :)

@jdnichollsc
Copy link
Member

Hello folks, Do you know any good npm package to analyze bundle size locally?

@jdnichollsc
Copy link
Member

Please let me know if the issue persist, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants