From f445eab230bfd0719a845b3fe09d808fa6ed760f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gu=C3=B0ni=20M=C3=A1r=20Gilbert?= Date: Sat, 4 May 2024 00:22:17 +0000 Subject: [PATCH 1/2] MMU: Add workaround for broken Tune button If the MMU is processing a command, the Tune button can't be executed. Change in memory: Flash: +16 bytes SRAM: 0 bytes --- Firmware/mmu2_reporting.cpp | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Firmware/mmu2_reporting.cpp b/Firmware/mmu2_reporting.cpp index 86db073343..428136b3ad 100644 --- a/Firmware/mmu2_reporting.cpp +++ b/Firmware/mmu2_reporting.cpp @@ -464,6 +464,15 @@ void tuneIdlerStallguardThresholdMenu() { } void tuneIdlerStallguardThreshold() { + if ((CommandInProgress)mmu2.GetCommandInProgress() != NoCommand) + { + // Workaround to mitigate an issue where the Tune menu doesn't + // work if the MMU is running a command. For example the Idler + // homing fails during toolchange. + // To save the print, make the Tune button unresponsive for now. + return; + } + putErrorScreenToSleep = true; menu_submenu(tuneIdlerStallguardThresholdMenu); } From 63e6d63baf114fb141e23a564628f171aaaa16cb Mon Sep 17 00:00:00 2001 From: 3d-gussner <3d.gussner@gmail.com> Date: Mon, 6 May 2024 13:02:05 +0200 Subject: [PATCH 2/2] Remove whitespace --- Firmware/mmu2_reporting.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Firmware/mmu2_reporting.cpp b/Firmware/mmu2_reporting.cpp index 428136b3ad..492fbb1cf5 100644 --- a/Firmware/mmu2_reporting.cpp +++ b/Firmware/mmu2_reporting.cpp @@ -472,7 +472,7 @@ void tuneIdlerStallguardThreshold() { // To save the print, make the Tune button unresponsive for now. return; } - + putErrorScreenToSleep = true; menu_submenu(tuneIdlerStallguardThresholdMenu); }