Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanks for the WASM build! #34

Open
garethky opened this issue Nov 28, 2023 · 3 comments
Open

Thanks for the WASM build! #34

garethky opened this issue Nov 28, 2023 · 3 comments

Comments

@garethky
Copy link

It was really easy to add support for parsing bgcode files to my project. Thank you to whomever it was that put the time into adding the wasm/emscripten build.

If I had one suggestion, it would be to not name your global Module. Name it BGcodeModule or something unique. When you get releases sorted out we can write some typescript bindings for it and make an NPM module.

@voxpelli
Copy link

voxpelli commented Feb 5, 2024

Do note that this code is licensed under AGPL (see eg #24) requiring that your project also uses AGPL, but I see that you are using GPL3 instead?

@garethky
Copy link
Author

garethky commented Feb 5, 2024

Good news: the AGPL v3 and GPL v3 specifically have cross-compatibility clauses for this use case: https://en.wikipedia.org/wiki/Affero_General_Public_License#Compatibility_with_the_GPL

@voxpelli
Copy link

voxpelli commented Feb 5, 2024

Yeah:

  1. Remote Network Interaction; Use with the GNU General Public License.

Notwithstanding any other provision of this License, if you modify the Program, your modified version must prominently offer all users interacting with it remotely through a computer network (if your version supports such interaction) an opportunity to receive the Corresponding Source of your version by providing access to the Corresponding Source from a network server at no charge, through some standard or customary means of facilitating copying of software. This Corresponding Source shall include the Corresponding Source for any work covered by version 3 of the GNU General Public License that is incorporated pursuant to the following paragraph.

Notwithstanding any other provision of this License, you have permission to link or combine any covered work with a work licensed under version 3 of the GNU General Public License into a single combined work, and to convey the resulting work. The terms of this License will continue to apply to the part which is the covered work, but the work with which it is combined will remain governed by version 3 of the GNU General Public License.

But does mean that the AGPL terms apply to that code at least so you will be having an AGPL project in disguise kind of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants