Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to log full ssz data on rejected gossip messages #11431

Closed
potuz opened this issue Sep 10, 2022 · 1 comment · Fixed by #11524
Closed

Add option to log full ssz data on rejected gossip messages #11431

potuz opened this issue Sep 10, 2022 · 1 comment · Fixed by #11524

Comments

@potuz
Copy link
Contributor

potuz commented Sep 10, 2022

Learned from @ajsutton that this is what Teku does and it's very handy, for example we remove invalid blocks from DB, we may keep the data in the logs.

@ajsutton
Copy link

This is useful, but worth noting that it is a potential DoS vector as you can wind up logging quite a lot if someone keeps sending you large invalid messages. You'll likely want to only enable it on nodes not doing anything else important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants