Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator Client in REST mode should not drop URL query strings #14528

Open
james-prysm opened this issue Oct 11, 2024 · 0 comments
Open

Validator Client in REST mode should not drop URL query strings #14528

james-prysm opened this issue Oct 11, 2024 · 0 comments
Labels
API Api related tasks Discussion Simply a thread for talking about stuff

Comments

@james-prysm
Copy link
Contributor

💎 Issue

Background

a user wasn't able to include GCP API_KEYS in the URL due to

  1. prysm dropping the query strings from URLs https://github.com/prysmaticlabs/prysm/blob/develop/api/client/client.go#L64
  2. prysm not allowing custom headers for validator client API calls

Solution

Ideally we either allow for query strings or maybe allow custom headers for API calls?
@james-prysm james-prysm added Discussion Simply a thread for talking about stuff API Api related tasks labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Api related tasks Discussion Simply a thread for talking about stuff
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@james-prysm and others