Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typehinting for Mongo Operations Service #35

Open
Maelstromeous opened this issue Oct 4, 2020 · 0 comments
Open

Fix typehinting for Mongo Operations Service #35

Maelstromeous opened this issue Oct 4, 2020 · 0 comments
Assignees
@Maelstromeous @microwavekonijn
Labels
enhancement New feature or request p2 Disruptive issues but not show stoppers
Milestone
API vTBC

Comments

@Maelstromeous
Copy link
Member

src/services/mongo/mongo.operations.service.ts

Currently we're using a feckton of any or any[] typecasts, which is breaking the point of using TypeScript. I was struggling to figure out how to supply the entity type to the function and make it return correctly, due to some weirdity with Mongo and how it returns entities not being compatible.
@Maelstromeous Maelstromeous added enhancement New feature or request p2 Disruptive issues but not show stoppers labels Oct 4, 2020
@Maelstromeous Maelstromeous added this to the API 3.0 Alpha milestone Oct 4, 2020
@Maelstromeous Maelstromeous modified the milestones: API 3.0 GA, API v4.2 Mar 7, 2022
@Maelstromeous Maelstromeous modified the milestones: API v4.2, API v4.3 Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Maelstromeous Maelstromeous

@microwavekonijn microwavekonijn

Labels
enhancement New feature or request p2 Disruptive issues but not show stoppers
Projects
PS2Alerts Roadmap
Status: Todo
Milestone
API vTBC
Development

No branches or pull requests
2 participants
@Maelstromeous @microwavekonijn