Address breakage of our test suite *before* aiohttp 4.0.0 goes out of alpha #2971
Labels
C: maintenance
Related to project maintenance, e.g. CI, testing, policy changes, releases
help wanted
Extra attention is needed
So thanks to the various dependency related fires we've had lately, I've created ichard26/black-deps-ci which runs Black's test suite using the latest development versions for most of our dependencies (exceptions being subdependencies and most of the test dependencies) *daily*
Turns out there's a lot of overrides necessary for CI to be green. Python 3.6 support being dropped is responsible for the vast majority of overrides, but on the other hand, aiohttp breaks our test suite as the
aiohttp.test_utils.unittest_run_loop
decorator was removed 🙃https://github.com/ichard26/black-deps-ci/blob/4e25ac3dea340a956e35dab37b2ac5c4177c105e/generate.py#L9-L24
And FYI, we've been warned about this in CI: https://github.com/psf/black/runs/5727523727?check_suite_focus=true#step:6:325
The best solution is probably to allow the import to fail replacing
unittest_run_loop
with just a no-op decorator. Although I wouldn't object to bumping up our aiohttp lower bound.The text was updated successfully, but these errors were encountered: