Fix #292: disuse HTTPResponse.strict #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dairiki
force-pushed
the
fix.292-disuse-strict
branch
from
1880ae3 to
79e3091
Compare
The `strict` attribute of `HTTPResponse` is gone in `urllib3>=2.0`. In addition it has no effect, at least when running under Python 3.
This prevents issues when deserializing responses serialized by an earlier version of cachecontrol.
Patch all the possible methods that might be used to generate a response.
dairiki
force-pushed
the
fix.292-disuse-strict
branch
from
79e3091 to
b91b7eb
Compare
frostming
approved these changes
May 25, 2023
4 tasks
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
May 30, 2023
https://build.opensuse.org/request/show/1089718 by user dgarcia + dimstar_suse - Add requests-fix.patch to support latest version of urllib3 and requests gh#psf/cachecontrol#301, gh#psf/cachecontrol#304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative PR to #294. It is more-or-less functionally equivalent to that PR. This alternative is being provided in case it turns out that the only reason #294 isn't being merged is that it includes formatting changes, etc. There are a couple of comments that indicate that might be the case. It seems that #292 affects a sufficiently wide collection of users that a timely fix is important.
Fixes #292
Fixes #293
What is here
strictattribute from the HTTPRequest (de)serialization.test_etag.pyforrequests>=2.29.Notes
As noted in this comment on #294, the
strictparameter only has an effect if running under Python 2. Since cachecontrol no longer supports Python 2 there is no reason not to remove support forstrictaltogether (as is done here).