Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Upload #2025

Closed
kennethreitz opened this issue Apr 28, 2014 · 11 comments · Fixed by #2258
Closed

JSON Upload #2025

kennethreitz opened this issue Apr 28, 2014 · 11 comments · Fixed by #2258

Comments

@kennethreitz
Copy link
Contributor

We download it but don't upload it. Asymmetrical.

r = requests.post('http://httpbin.org/post', json={'life': 42'})
@sigmavirus24
Copy link
Contributor

This is really easy to do. I'm curious though, what made you change your mind about this?

@Lukasa
Copy link
Member

Lukasa commented Apr 29, 2014

Tagging this as contributor friendly because it's perfect for @sigmavirus24 to pair with a new developer on.

@smallcode
Copy link

cool!

@dominikgehl
Copy link

Did anyone already start working on it ? If not, I would be interested in giving it a try ...

@sigmavirus24
Copy link
Contributor

@willingc and I are working on this.

@sigmavirus24 sigmavirus24 self-assigned this May 2, 2014
@sahildua2305
Copy link

Is anyone still working on it? Otherwise I will be happy to work on this as my first issue ever. Please let me know if I can contribute. :)

@sigmavirus24
Copy link
Contributor

Yes they are. Please be patient.

Sent from my Android device with K-9 Mail. Please excuse my brevity.

@gbromios
Copy link

I've just been doing requests.post('http://httpbin.org/post', data=json.dumps({'life':42})); is there some limitation I'm missing about doing that way?

@Lukasa
Copy link
Member

Lukasa commented Jun 17, 2014

@gbromios That's the only way to do it at the moment. Note, however, that the Content-Type is wrong. =)

@gbromios
Copy link

ah, so convert to a string and override the Content-Type header in one step. That seems reasonable.

@kennethreitz
Copy link
Contributor Author

Yeah — basically if we do it on one side (download), we should also do it on the other (upload). Nice and symmetrical.

@akhomchenko akhomchenko mentioned this issue Sep 30, 2014
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants